Hi lamber,

+1 from my side.

IMO, it would be better to refactor step by step like java style. Firstly,
we should refactor code based on warning message, then change the
checkstyle rule level.

WDYT? Is it what you prepare to do?

Best,
Vino


lamberken <[email protected]> 于2019年12月6日周五 下午2:39写道:

> Hi,
>
>
> Currently, the level of scala codestyle rule is warning, it's better check
> these rules one by one
> and refactor scala codes then now.
>
>
> Furthermore, in order to sync to java codestyle, needs to add two rules.
> One is BlockImportChecker
> which allows to ensure that only single imports are used in order to
> minimize merge errors in import declarations, another is ImportOrderChecker
> which checks that imports are grouped and ordered according to the style
> configuration.
>
>
> Summary
> 1, check scala checkstyle rules one by one, change some warning level to
> error.
> 2, add ImportOrderChecker and BlockImportChecker.
>
>
> Any comments and feedback are welcome, WDYT?
>
>
> Best,
> lamber-ken

Reply via email to