Hi Vinoth,
Thanks for your affirmation, here is pr
https://github.com/apache/incubator-hudi/pull/1120
best,
lamber-ken
On 12/21/2019 07:59，Vinoth Chandar<[email protected]> wrote：
Hi lamber,
Given we have enough +1s on the look and feel aspects, I propose we open a
PR and iron out the content/remaining issues there one by one.
I think a full line by line review is the best way to go, as with any code
change
Please share the PR here once you have it
Thanks
Vinoth
On Fri, Dec 20, 2019 at 3:55 PM lamberken <[email protected]> wrote:
Hi leesf,
Thank you for your affirmation.
best,
lamber-ken
At 2019-12-21 07:28:50, "leesf" <[email protected]> wrote:
Hi lamber,
Thanks for your great work, the new website looks much better.
Also if you guys have other companies(logos) needed to add to powered
by(Hudi Users)[1], please let lamberken/me know before using new website.
Best,
Leesf
[1] https://lamber-ken.github.io/
lamberken <[email protected]> 于2019年12月20日周五 上午9:29写道：
Hi nishith,
Thank you for your affirmation. The content in the blue box is to help us
understand the highlighted content.
It is different from the body content, so we need it. There are several
ways to present it, for examples.
best,
lamber-ken
At 2019-12-20 05:57:16, "nishith agarwal" <[email protected]> wrote:
Great job Lamber!
The website looks really slick and has a much better experience of moving
from one page to another (mostly I think because it's faster), also find
it
the text much more conducive to absorb.
While going through the quick start, I noticed that under the highlighted
box in dark (showing the code pieces), there's another highlighted box (in
light blue) which talks about more details. Do we need that ? May be the
details in that box can just follow the plain text style of other parts on
that page.
-Nishith
On Wed, Dec 18, 2019 at 10:59 PM vino yang <[email protected]> wrote:
Hi Lamber,
Awesome! Thanks for your hard work.
Best,
Vino
lamberken <[email protected]> 于2019年12月19日周四 下午2:11写道：
Hi everyone,
I finished the rework of the new UI, if you have time, please visit
the
website[1].
Any questions are welcome.
[1]https://lamber-ken.github.io/docs/quick-start-guide/
best,
lamber-ken
At 2019-12-19 07:38:47, "lamberken" <[email protected]> wrote:
Hi @Shiyan Xu
Thanks. :)
best,
lamber-ken
At 2019-12-19 00:53:51, "Shiyan Xu" <[email protected]>
wrote:
Thank you @lamber-ken for the work! It is definitely a greater
browsing
experience.
On Tue, Dec 17, 2019 at 8:28 PM lamberken <[email protected]>
wrote:
Hi, @Vinoth
I'm glad to hear your thoughts on the new UI, thanks. So we keep
its
style
as it is now.
The development of new UI can be completed these days, any
questions
are
welcome.
best,
lamber-ken
At 2019-12-18 11:44:27, "Vinoth Chandar" <
[email protected]>
wrote:
The case for right navigation for me, is mainly from pages like
https://lamber-ken.github.io/docs/docker_demo
https://lamber-ken.github.io/docs/querying_data
https://lamber-ken.github.io/docs/writing_data
which often have commands/text you want to selectively copy paste
from a
section.
For content you read sequentially, it matters less. I agree..
BTW the new site looks very sleek.. :)
On Tue, Dec 17, 2019 at 4:50 PM lamberken <[email protected]>
wrote:
hi, allOne more thing that is missing.In the new UI, I put a
"BACK
TO
TOP"
button at the bottom of all pages to help us back to top.
We can also discuss whether we need the right navigation at the
community
meeting today.best,
lamber-ken
At 2019-12-18 08:41:49, "lamberken" <[email protected]> wrote:
Hi @Vinoth,
Thanks for raising this point, but I have some different
views.
I've thought about it very seriously before, and I remove the
right
navigation finally.
1, I have a deep analysis of the characteristics of our
documents,
most
of them have many
commands, if the right navigation exists, it will affect
us
to
read.
2, Most documents are short, we can visit them all just at one
page.
3, The max width of web page is 1280px, left navigation is
250px(at
least), right navigation is 250px(at least),
if so, the width of the main content is only left 800px,
may
it's
not
suitable for readers.
4, I also analysised other projects, like
1) flink, spark, zeppelin, kafka, superset, elasticsearch,
arrow,
kudu, hadoop don't have right navigation
2) druid, kylin, beam have right navigation.
These are my personal views. Welcome all community members to
join
in
the
discussion.
In the end, I will follow our community, thanks.
BTW, I have synced most of the documents[1], we can use these
documents
as a reference to see
if we need the navigation bar on the right in the new UI.
[1] https://lamber-ken.github.io/docs/admin_guide
[2] https://lamber-ken.github.io/docs/writing_data
[3] https://lamber-ken.github.io/docs/quick-start-guide/
best,
lamber-ken
At 2019-12-18 04:44:04, "Vinoth Chandar" <[email protected]>
wrote:
One more thing that is missing.
Current site has a navigation links on the right, which lets
you
jump
to
the right section directly. This is also a must-have IMHO.
I would suggest wait for more folks to come back from
vacation,
before we
finalize anything on this, as there could be more feedback
On Mon, Dec 16, 2019 at 9:15 PM lamberken <[email protected]
wrote:
Hi Vinoth,
1, I'll update the site content this week, clean some
useless
templete
codes, adjust the content etc...
It will take a little long time for syncing the
content.
2, I will adjust the style as much as I can to keep the
theming
blue
and
white.
When the above work is completed, I will notify you all
again.
best,
lamber-ken
At 2019-12-17 12:49:23, "Vinoth Chandar" <
[email protected]>
wrote:
Hi Lamber,
+1 on the look and feel. Definitely feels slick and fast.
Love
the
syntax
highlighting.
Few things :
- Can we just update the site content as-is? ( I'd rather
change
just
the
look-and-feel and evolve the content from there, per usual
means)
- Can we keep the theming blue and white, like now, since
it
gels
well
with
the logo and images.
On Mon, Dec 16, 2019 at 8:02 AM lamberken <
[email protected]
wrote:
Thanks for your reply @lees @vino @vinoth :)
best,
lamber-ken
在 2019-12-16 12:24:26，"leesf" <[email protected]> 写道：
Hi Lamber,
Thanks for your work, have gone through the new web ui,
looks
good.
Hence +1 from my side.
Best,
Leesf
vino yang <[email protected]> 于2019年12月16日周一
上午10:17写道：
Hi Lamber,
I am not an expert on Jekyll. But big +1 for your
proposal to
improve
the
site.
Best,
Vino
Vinoth Chandar <[email protected]> 于2019年12月16日周一
上午3:15写道：
Thanks for taking the time to improve the site.
Will
review
closely
and
get
back to you.
On Sun, Dec 15, 2019 at 11:02 AM lamberken <
[email protected]>
wrote:
Hello, everyone.
Compare to the web site of Delta Lake[1] and
Apache
Iceberg[2],
they
may
looks better than hudi project[3].
I delved into our web ui and try to improve it, I
learned
that
hudi
web
ui
is based on jekyll-doc[4] theme
which is not active. So it needs us to find a new
active
theme.
So I try my best to find a free and beatiful
theme
in
the
past.
Fortunately, I found a suitable theme
in the huge amount of themes(check them one by
one).
It is
minimal-mistakes[5], it's very popular and 100%
free.
Based on minimal theme, I rework a basic new web
ui
framework. I
adjust
some css styles, nav bars and etc..
If you are interested in this, please visit
https://lamber-ken.github.io
for a quick overview.
I’m looking forward to your reply, thanks!
[1] https://delta.io
[2] https://iceberg.apache.org
[3] http://hudi.apache.org
[4]
https://github.com/tomjoht/documentation-theme-jekyll
[5]
https://github.com/mmistakes/minimal-mistakes
best,
lamber-ken
