Hey Ethan, Thanks for raising this up again. Before we go to fixes, may be it would good to summarize the current problems one by one. We can then discuss options?
I have been using checkstyle files to format and it’s been tolerable. Import order etc does not work. But we have turned it off. Thanks Vinoth On Fri, Feb 28, 2020 at 12:47 PM Y Ethan Guo <ethan.guoyi...@gmail.com> wrote: > Reviving this thread... > > I'm hitting checkstyle issues locally again and thinking that it might be > worth trying GJF. It interoperates well with IntelliJ and the automated > tool reformats the code in 1 shot as Minh suggested. > > If sweeping checkstyle fixes in the codebase disrupts development, we can > temporarily disable checkstyle in this case and for each future PR, we > generate a corresponding cleanup PR just for the changed files (maybe a > script to autogen the clean PR?), to reformat code incrementally. > > wdyt? > > Best, > - Ethan > > On Mon, Dec 23, 2019 at 6:24 PM lamber...@163.com <lamber...@163.com> > wrote: > > > >
