+1 on Junit5. does seem nicer with support for lambdas. assuming we do a gradual rollout. At any point, we cannot have any of the core tests disabled :) May be we can use the vintage framework for now, do minimal changes migrate and then proceed to redoing the tests
On AssertJ type frameworks, I wonder if there is a cost to this type of framework for new devs. They already need to learn junit 5, mockito, all the TestUtils and like one more framework for asserting Orthogonally, I will be thrilled if you also took upon a large restructuring on tests cleanly into - unit tests that test class functionality using mocks - functional tests that bring up a spark context and actually run the job (we have a lot of these tests masquerading as unit tests) - Clean redesign of the test utility classes Sorry to expand scope, but when someone is going to take a look at every test, I could not pass up an opportunity to sneak this in :) Love to hear others thoughts.. any one with experience working with Junit5/Assertj-Hamcrest? On Tue, Mar 24, 2020 at 9:36 PM Shiyan Xu <xu.shiyan.raym...@gmail.com> wrote: > Some references > https://junit.org/junit5/docs/current/user-guide/ > https://joel-costigliola.github.io/assertj/ > > On Tue, Mar 24, 2020 at 9:27 PM Shiyan Xu <xu.shiyan.raym...@gmail.com> > wrote: > > > Hi all, > > > > I'd like to gather some feedback about > > 1. upgrading Junit 4 to 5 > > 2. adopt AssertJ as preferred assertion statement style > > > > IMO 1) will give many benefits on writing better unit tests. A google > > search of "junit 4 vs 5" could lead to many good points. And it is some > > migration can be done piece by piece (keeping both 4 and 5 during upgrade > > and enforce new test using 5) > > > > 2) is to spice things up and bring the test readability to another level, > > though I'll treat it as nice-to-have. > > > > Would you +1 or -1 on either or both? > > > > Knowing that it'll be a long way to go due to the large number of tests, > > this needs to be planned and tracked carefully. > > > > Thank you. > > > > Best, > > Raymond > > > > >
