+1 as well. Given we support many reporters now. Could you please further improve/retain modularity.
On Mon, Jul 27, 2020 at 6:30 PM vino yang <[email protected]> wrote: > Hi Modi, > > +1 for this proposal. > > I agree with your opinion that the metric report should not only report the > client's metrics. > > And we should decouple the implementation of metrics from the client module > so that it could be developed independently. > > Best, > Vino > > Abhishek Modi <[email protected]> 于2020年7月28日周二 上午4:17写道： > > > Hi Everyone! > > > > I'm hoping to have a discussion around adding a lightweight metrics class > > to Hudi Common. There are parts of Hudi Common that have large > performance > > implications, and I think adding metrics to these parts will help us > track > > Hudi's health in production and help us understand the performance > > implications of changes we make. > > > > I've opened a Jira on this topic - > > https://issues.apache.org/jira/browse/HUDI-1025. This jira > > specifically suggests adding HoodieWrapperFileSystem as this class has > > performance implications not just for Hudi, but also for the underlying > > DFS. > > > > Looking forward to everyone's opinions on this :) > > > > Best, > > Modi > > >
