[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1852: fix core-backend checkstyle issue

[GitBox]

javeme commented on code in PR #1852:
URL: 
https://github.com/apache/incubator-hugegraph/pull/1852#discussion_r864427680


##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdRangeQuery.java:
##########
@@ -102,12 +102,12 @@ public String toString() {
         assert sb.length() > 0;
         sb.deleteCharAt(sb.length() - 1); // Remove the last "`"
         sb.append(" id in range ")
-          .append(this.inclusiveStart ? "[" : "(")
-          .append(this.start)
-          .append(", ")
-          .append(this.end)
-          .append(this.inclusiveEnd ? "]" : ")")
-          .append("`");
+            .append(this.inclusiveStart ? "[" : "(")

Review Comment:
   can rename to `StringBuilder builder `



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java:
##########
@@ -111,6 +111,7 @@ private void optimizeUpdates(BackendEntry entry, Action 
action) {
                                   " transaction between %s and %s",
                                   entry, originItem.entry()));
                     }
+                    break;

Review Comment:
   please check whether it's required by code logic



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java:
##########
@@ -111,62 +120,57 @@ public default void setCounterLowest(HugeType type, long 
lowest) {
         this.increaseCounter(type, increment);
     }
 
-    public default String olapTableName(HugeType type) {
+    default String olapTableName(HugeType type) {
         StringBuilder sb = new StringBuilder(7);
         sb.append(this.store())
-          .append("_")
-          .append(HugeType.OLAP.string())
-          .append("_")
-          .append(type.string());
+            .append("_")

Review Comment:
   ditto



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java:
##########
@@ -424,7 +422,7 @@ private IdHolderList queryByLabel(ConditionQuery query) {
         }
 
         ConditionQuery indexQuery;
-        indexQuery = new ConditionQuery(indexType , query);
+        indexQuery = new ConditionQuery(indexType, query);

Review Comment:
   can merge into line 424



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java:
##########
@@ -111,62 +120,57 @@ public default void setCounterLowest(HugeType type, long 
lowest) {
         this.increaseCounter(type, increment);
     }
 
-    public default String olapTableName(HugeType type) {
+    default String olapTableName(HugeType type) {
         StringBuilder sb = new StringBuilder(7);
         sb.append(this.store())
-          .append("_")
-          .append(HugeType.OLAP.string())
-          .append("_")
-          .append(type.string());
+            .append("_")
+            .append(HugeType.OLAP.string())
+            .append("_")
+            .append(type.string());
         return sb.toString().toLowerCase();
     }
 
-    public default String olapTableName(Id id) {
+    default String olapTableName(Id id) {
         StringBuilder sb = new StringBuilder(5 + 4);
         sb.append(this.store())
-          .append("_")
-          .append(HugeType.OLAP.string())
-          .append("_")
-          .append(id.asLong());
+            .append("_")

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org