imbajin commented on code in PR #392:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/392#discussion_r1042029959
##########
hugegraph-dist/pom.xml:
##########
@@ -36,8 +36,8 @@
mkdir -p ${final.name}
mv
$root_path/hugegraph-hubble/hugegraph-hubble
${final.name}/hugegraph-hubble-${project.version}
- mv
$root_path/hugegraph-loader/hugegraph-loader-${project.version}
${final.name}/hugegraph-loader-${project.version}
- mv
$root_path/hugegraph-tools/hugegraph-tools-${project.version}
${final.name}/hugegraph-tools-${project.version}
+ mv
$root_path/hugegraph-loader/apache-hugegraph-loader-incubating-${project.version}
${final.name}/apache-hugegraph-loader-incubating-${project.version}
+ mv
$root_path/hugegraph-tools/apache-hugegraph-tools-incubating-${project.version}
${final.name}/apache-hugegraph-tools-incubating-${project.version}
Review Comment:
@z7658329 `hubble` should also rename to apache, and remember check the
string path in IDEA (search usage) to avoid inconsistency
and 2 improvement:
1. use `mv -v` to show the verbose info
2. condiser use `$root_path/apache-hugegraph-*-incubating*/` ? (need test it
first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
