coderzc commented on code in PR #394:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/394#discussion_r1043138281
##########
hugegraph-tools/pom.xml:
##########
@@ -235,9 +235,11 @@
<configuration>
<target>
<tar
destfile="${project.basedir}/${final.name}.tar.gz"
Review Comment:
```suggestion
<tar
destfile="${project.basedir}/target/${final.name}.tar.gz"
```
##########
hugegraph-loader/pom.xml:
##########
@@ -650,9 +650,11 @@
<configuration>
<target>
<tar
destfile="${project.basedir}/${final.name}.tar.gz"
- basedir="${project.basedir}"
- includes="${final.name}/**"
- compression="gzip"/>
+ compression="gzip">
+ <tarfileset dir="${project.basedir}"
filemode="755">
Review Comment:
why is `${project.basedir}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
