imbajin commented on code in PR #392:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/392#discussion_r1043470978
##########
hugegraph-dist/pom.xml:
##########
@@ -36,8 +36,8 @@
mkdir -p ${final.name}
mv
$root_path/hugegraph-hubble/hugegraph-hubble
${final.name}/hugegraph-hubble-${project.version}
- mv
$root_path/hugegraph-loader/hugegraph-loader-${project.version}
${final.name}/hugegraph-loader-${project.version}
- mv
$root_path/hugegraph-tools/hugegraph-tools-${project.version}
${final.name}/hugegraph-tools-${project.version}
+ mv
$root_path/hugegraph-loader/apache-hugegraph-loader-incubating-${project.version}
${final.name}/apache-hugegraph-loader-incubating-${project.version}
+ mv
$root_path/hugegraph-tools/apache-hugegraph-tools-incubating-${project.version}
${final.name}/apache-hugegraph-tools-incubating-${project.version}
Review Comment:
> <img alt="image" width="457"
src="https://user-images.githubusercontent.com/5474723/206377063-b2319f17-d6f0-4f51-9e2a-1d9f06c22647.png";>
>
> run ' mvn install' in hugegraph-hubble dir, it seems Generate two
identical files? should remove one of them? @javeme @imbajin
emm, seems keep one dir is right.. handle it in another PR together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/5474723/206377063-b2319f17-d6f0-4f51-9e2a-1d9f06c22647.png"](https://user-images.githubusercontent.com/5474723/206377063-b2319f17-d6f0-4f51-9e2a-1d9f06c22647.png"){kind=link}