imbajin commented on code in PR #400:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/400#discussion_r1058371907


##########
pom.xml:
##########
@@ -481,13 +350,163 @@
                 </executions>
             </plugin>
         </plugins>
-
-<!--        <testResources>-->
-<!--            <testResource>-->
-<!--                <directory>src/test/resources/</directory>-->
-<!--                <filtering>true</filtering>-->
-<!--            </testResource>-->
-<!--        </testResources>-->
+        <!-- Note: plugin will not execute in management by default in root -->
+        <pluginManagement>
+            <plugins>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-compiler-plugin</artifactId>
+                    <configuration>
+                        <source>${compiler.source}</source>
+                        <target>${compiler.target}</target>
+                        <encoding>${project.build.sourceEncoding}</encoding>
+                        <compilerArguments>
+                            <Xmaxerrs>500</Xmaxerrs>
+                        </compilerArguments>
+                        <compilerArgs>
+                            <arg>-Xlint:unchecked</arg>
+                        </compilerArgs>
+                    </configuration>
+                </plugin>
+                <!--            <plugin>-->

Review Comment:
   > useless code? add some comments if keep this code
   
   handle them later (not test well now)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to