imbajin commented on code in PR #415:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/415#discussion_r1066658201


##########
hugegraph-hubble/hubble-dist/assembly/static/bin/start-hubble.sh:
##########
@@ -78,7 +79,7 @@ args=${CONF_PATH}/hugegraph-hubble.properties
 log=${LOG_PATH}/hugegraph-hubble.log
 
 echo -n "starting HugeGraphHubble "
-nohup nice -n 0 java -server "${java_opts}" -Dhubble.home.path="${HOME_PATH}" 
-cp "${class_path}" ${main_class} "${args}" > "${log}" 2>&1 < /dev/null &
+nohup nice -n 0 java -server "${java_opts}" ${java_debug_opts} 
-Dhubble.home.path="${HOME_PATH}" -cp "${class_path}" ${main_class} "${args}" > 
"${log}" 2>&1 < /dev/null &

Review Comment:
   should also remove useless `""` to avoid strange error
   
   and anyone knows why `java -server "${java_opts}"` throw error but `java 
-server ${java_opts}` is OK? @zyxxoo @javeme 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to