imbajin commented on code in PR #2091:
URL:
https://github.com/apache/incubator-hugegraph/pull/2091#discussion_r1070499687
##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeVertex.java:
##########
@@ -462,10 +464,14 @@ public <V> VertexProperty<V> property(
E.checkArgument(!this.hasProperty(propertyKey.id()),
"Can't update primary key: '%s'", key);
}
+ if (value == null) {
+ this.removeProperty(propertyKey.id());
+ return EmptyVertexProperty.instance();
+ }
Review Comment:
> prefer to move this block into PR #206 for consistent logic.
Not quite clear, something wrong? And commit in release branch has
cherry-picked to it
<img width="904" alt="image"
src="https://user-images.githubusercontent.com/17706099/212523208-4da913fa-75de-4b74-aa8c-c354ee7eb627.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/17706099/212523208-4da913fa-75de-4b74-aa8c-c354ee7eb627.png"](https://user-images.githubusercontent.com/17706099/212523208-4da913fa-75de-4b74-aa8c-c354ee7eb627.png"){kind=link}