javeme commented on code in PR #2091:
URL:
https://github.com/apache/incubator-hugegraph/pull/2091#discussion_r1070527212
##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeEdge.java:
##########
@@ -362,6 +367,7 @@ public void vertices(HugeVertex owner, HugeVertex other) {
if (ownerLabel.equals(this.label.sourceLabel())) {
this.vertices(true, owner, other);
} else {
+ // TODO: why compare the label but ignore the result?
Review Comment:
assert ownerLabel.equals(this.label.targetLabel());
##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeVertex.java:
##########
@@ -462,10 +464,14 @@ public <V> VertexProperty<V> property(
E.checkArgument(!this.hasProperty(propertyKey.id()),
"Can't update primary key: '%s'", key);
}
+ if (value == null) {
+ this.removeProperty(propertyKey.id());
+ return EmptyVertexProperty.instance();
+ }
Review Comment:
that's ok if it has been cherry-picked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
