imbajin commented on code in PR #2100:
URL:
https://github.com/apache/incubator-hugegraph/pull/2100#discussion_r1093515695
##########
hugegraph-dist/src/assembly/descriptor/assembly.xml:
##########
@@ -51,10 +51,6 @@
<fileSet>
<directory>${top.level.dir}/hugegraph-dist/release-docs/</directory>
<outputDirectory>/</outputDirectory>
- <includes>
- <include>LICENSE*</include>
- <include>NOTICE*</include>
- </includes>
Review Comment:
remember to check it in binary release file (could use [validate
action](https://github.com/apache/incubator-hugegraph/actions/workflows/validate-release.yml)
after we publish it to svn)
##########
hugegraph-dist/src/assembly/travis/run-api-test.sh:
##########
@@ -35,6 +35,10 @@ mvn package -DskipTests
# add mysql dependency
wget -P $SERVER_DIR/lib/
https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.28/mysql-connector-java-8.0.28.jar
+if [[ ! -e "$SERVER_DIR/ikanalyzer-2012_u6.jar" ]]; then
+ wget -P $SERVER_DIR/lib/
https://raw.githubusercontent.com/apache/incubator-hugegraph-doc/ik_binary/dist/server/ikanalyzer-2012_u6.jar
Review Comment:
is the url fixed already? (before we merge the PR in doc repo)
##########
NOTICE:
##########
@@ -5,3 +5,34 @@ This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
The initial codebase was donated to the ASF by HugeGraph Authors, copyright
2017-2021.
+
+
+// ------------------------------------------------------------------
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for JanusGraph
+// ------------------------------------------------------------------
+
+JanusGraph
+Copyright (C) 2002, 2016, Oracle and/or its affiliates. All rights reserved.
Review Comment:
shall we add it in binary release `NOTICE` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
