javeme commented on code in PR #197:
URL:
https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1105879056
##########
.github/workflows/validate-release.yml:
##########
@@ -212,8 +236,6 @@ jobs:
cd dist/${{ inputs.release_version }}
cd ./*hugegraph-incubating*${{ inputs.release_version }} || exit
bin/init-store.sh && sleep 1
- # kill the HugeGraphServer process by jps
- jps | grep HugeGraphServer | awk '{print $1}' | xargs kill -9
Review Comment:
we must stop the old one, otherwise can't start the new one
##########
.github/workflows/validate-release.yml:
##########
@@ -180,6 +182,7 @@ jobs:
echo "test hubble"
cd ./*hubble*${{ inputs.release_version }} || exit
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
+ # TODO: need stop the server here
Review Comment:
if it's difficult to find a time to stop, we can close the old one before
starting server.
##########
.github/workflows/validate-release.yml:
##########
@@ -245,8 +267,12 @@ jobs:
cat conf/hugegraph-hubble.properties
bin/stop-hubble.sh && bin/start-hubble.sh
cd - || exit
+ # TODO: need stop the server here
+ jps | grep HugeGraphServer | awk '{print $1}' | xargs kill -9
Review Comment:
sleep a while before the stop, like 60s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
