javeme commented on code in PR #2109:
URL:
https://github.com/apache/incubator-hugegraph/pull/2109#discussion_r1105897713
##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -87,91 +110,102 @@ for i in *src.tar.gz; do
cd .. || exit
done
-#### step4.3: run the compiled packages in server
+#### step5: run the compiled packages in server
ls -lh
cd ./*hugegraph-incubating*src/*hugegraph*"${RELEASE_VERSION}" || exit
bin/init-store.sh && sleep 1
bin/start-hugegraph.sh && ls ../../
cd ../../ || exit
-#### step4.4: run the compiled packages in toolchain (include
loader/tool/hubble)
+#### step6: run the compiled packages in toolchain (include loader/tool/hubble)
cd ./*toolchain*src || exit
ls -lh
cd ./*toolchain*"${RELEASE_VERSION}" || exit
ls -lh
-##### 4.4.1 test loader
+##### step6.1: test loader
cd ./*loader*"${RELEASE_VERSION}" || exit
bin/hugegraph-loader.sh -f ./example/file/struct.json -s
./example/file/schema.groovy \
-g hugegraph || exit
cd .. || exit
-##### 4.4.2 test tool
+##### step6.2: test tool
cd ./*tool*"${RELEASE_VERSION}" || exit
bin/hugegraph gremlin-execute --script 'g.V().count()' || exit
bin/hugegraph task-list || exit
bin/hugegraph backup -t all --directory ./backup-test || exit
cd .. || exit
-##### 4.4.3 test hubble
+##### step6.3: test hubble
cd ./*hubble*"${RELEASE_VERSION}" || exit
# TODO: add hubble doc & test it
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
cd ../../../ || exit
-# step5: validate the binary packages
-#### step5.0: check the directory name include "incubating"
-#### step5.1: check the directory include "NOTICE" and "LICENSE" file
+# step7: validate the binary packages
rm -rf ./*src* && ls -lh
for i in *.tar.gz; do
echo "$i"
+ #### step7.1: check the directory name include "incubating"
if [[ ! "$i" =~ "incubating" ]]; then
- echo "The package name should include incubating" && exit 1
+ echo "The package name:$i should include incubating" && exit 1
Review Comment:
"name:$i" -- prefer `name $i`
##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -25,6 +25,7 @@
URL_PREFIX="https://dist.apache.org/repos/dist/dev/incubator/hugegraph/";
# release version (input by committer)
RELEASE_VERSION=$1
JAVA_VERSION=$2
+USER=$3
Review Comment:
also move this file to hugegraph-doc repo?
##########
.github/workflows/validate-release.yml:
##########
@@ -1,21 +1,33 @@
-name: Validate Apache Release
-
+name: "Validate Apache Release"
+#latest please refer:
https://github.com/apache/incubator-hugegraph-doc/blob/master/.github/workflows/validate-release.yml
Review Comment:
can we just delete this file?
##########
hugegraph-dist/scripts/validate-release.sh:
##########
@@ -87,91 +110,102 @@ for i in *src.tar.gz; do
cd .. || exit
done
-#### step4.3: run the compiled packages in server
+#### step5: run the compiled packages in server
ls -lh
cd ./*hugegraph-incubating*src/*hugegraph*"${RELEASE_VERSION}" || exit
bin/init-store.sh && sleep 1
bin/start-hugegraph.sh && ls ../../
cd ../../ || exit
-#### step4.4: run the compiled packages in toolchain (include
loader/tool/hubble)
+#### step6: run the compiled packages in toolchain (include loader/tool/hubble)
cd ./*toolchain*src || exit
ls -lh
cd ./*toolchain*"${RELEASE_VERSION}" || exit
ls -lh
-##### 4.4.1 test loader
+##### step6.1: test loader
cd ./*loader*"${RELEASE_VERSION}" || exit
bin/hugegraph-loader.sh -f ./example/file/struct.json -s
./example/file/schema.groovy \
-g hugegraph || exit
cd .. || exit
-##### 4.4.2 test tool
+##### step6.2: test tool
cd ./*tool*"${RELEASE_VERSION}" || exit
bin/hugegraph gremlin-execute --script 'g.V().count()' || exit
bin/hugegraph task-list || exit
bin/hugegraph backup -t all --directory ./backup-test || exit
cd .. || exit
-##### 4.4.3 test hubble
+##### step6.3: test hubble
cd ./*hubble*"${RELEASE_VERSION}" || exit
# TODO: add hubble doc & test it
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
cd ../../../ || exit
-# step5: validate the binary packages
-#### step5.0: check the directory name include "incubating"
-#### step5.1: check the directory include "NOTICE" and "LICENSE" file
+# step7: validate the binary packages
rm -rf ./*src* && ls -lh
for i in *.tar.gz; do
echo "$i"
+ #### step7.1: check the directory name include "incubating"
if [[ ! "$i" =~ "incubating" ]]; then
- echo "The package name should include incubating" && exit 1
+ echo "The package name:$i should include incubating" && exit 1
Review Comment:
"name:$i" -- prefer` name $i`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
