imbajin commented on code in PR #2095:
URL:
https://github.com/apache/incubator-hugegraph/pull/2095#discussion_r1123323435
##########
hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java:
##########
@@ -137,18 +129,23 @@ public static byte[] compress(String value) {
}
public static byte[] compress(String value, float bufferRatio) {
- BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE,
- bufferRatio);
- return buf.bytes();
+ try (BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE,
bufferRatio)) {
+ return buf.bytes();
+ } catch (IOException e) {
Review Comment:
> yes the BytesBuffer don't need to close, it's just a memory buffer
OK, my previous consideration is that if the **buffer** is large(like
compress a big file), we should recycle it manually in time to reduce the
pressure of GC & memory usage, but lack enough validation, so back off for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
