imbajin commented on code in PR #131:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/131#discussion_r1163074932
##########
pom.xml:
##########
@@ -89,7 +89,7 @@
</scm>
<properties>
- <revision>1.0.0</revision>
+ <revision>1.0.1</revision>
Review Comment:
> If it is packaged in a jar, we cannot get the version from the pom.xml, so
it fallback to the default version.
OK, we could consider these way: (way2 is the easiest)
1. check if somewhere possible for us to put the `version` into the `jar`
file (like `meta` file/info of a jar?)
2. just leave a comment before `revision` param in pom file (devs could see
the `NOTE`)
3. remove the common version check, seems it's not necessary to check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
