imbajin commented on code in PR #135:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/135#discussion_r1405585509
##########
hugegraph-common/src/main/java/org/apache/hugegraph/testutil/Assert.java:
##########
@@ -104,34 +103,40 @@ public static void assertEquals(double expected, Object
actual) {
org.junit.Assert.assertEquals(expected, actual);
}
+ @SuppressWarnings("deprecation")
Review Comment:
use `@Deprecated` directly is better？It could remind user，so as others
##########
hugegraph-common/src/main/java/org/apache/hugegraph/util/ExceptionUtil.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2017 HugeGraph Authors
Review Comment:
we need remove this line & check-then-remove in all other files(if copy from
others)
##########
hugegraph-common/src/main/java/org/apache/hugegraph/testutil/Assert.java:
##########
@@ -104,34 +103,40 @@ public static void assertEquals(double expected, Object
actual) {
org.junit.Assert.assertEquals(expected, actual);
}
+ @SuppressWarnings("deprecation")
Review Comment:
use `@Deprecated` directly is better？It could remind user，so as others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
