haohao0103 opened a new issue, #2597:
URL: https://github.com/apache/incubator-hugegraph/issues/2597

   ### Bug Type (问题类型)
   
   logic (逻辑设计问题)
   
   ### Before submit
   
   - [X] 我已经确认现有的 [Issues](https://github.com/apache/hugegraph/issues) 与 
[FAQ](https://hugegraph.apache.org/docs/guides/faq/) 中没有相同 / 重复问题 (I have 
confirmed and searched that there are no similar problems in the historical 
issue and documents)
   
   ### Environment (环境信息)
   
   - Server Version: 1.5.0 (Apache Release Version)
   - Backend: RocksDB x nodes, HDD 
   
   
   ### Expected & Actual behavior (期望与实际表现)
   
   The pdconfig property in LogMeta and PartitionMeta is redundant
   
   MetadataRocksDBStore  has already defined the pdConfig property, it seems no 
need to redefine it in the subclass PartitionMeta
   ```
   public class MetadataRocksDBStore extends MetadataStoreBase {
   
       HgKVStore store;
   
       PDConfig pdConfig;
   
       public MetadataRocksDBStore(PDConfig pdConfig) {
           store = MetadataFactory.getStore(pdConfig);
           this.pdConfig = pdConfig;
       }
   ```
   
   ```
   public class PartitionMeta extends MetadataRocksDBStore {
   
       static String CID_GRAPH_ID_KEY = "GraphID";
       static int CID_GRAPH_ID_MAX = 0xFFFE;
       private final PDConfig pdConfig;
       private final PartitionCache cache;
   
       public PartitionMeta(PDConfig pdConfig) {
           super(pdConfig);
           this.pdConfig = pdConfig;
           //this.timeout = pdConfig.getEtcd().getTimeout();
           this.cache = new PartitionCache();
       }
   ```
   
   
   ### Vertex/Edge example (问题点 / 边数据举例)
   
   _No response_
   
   ### Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to