[
http://issues.apache.org/jira/browse/IBATISNET-105?page=comments#action_12323042
]
Ron Grabowski commented on IBATISNET-105:
-----------------------------------------
I'm having a hard time understanding the files inside LazyLoad_rev03.zip. I
assume the other .ZIP files are old and can be deleted...
Is LazyLoadProxyFactory a new class? Can you give another example (in code or
in writing) of what it does.
SimpleInterceptor isn't commented out, is that a new class too?
In SimpleInterceptor, I noticed there was a check to see the returnValue is a
Collection:
bool isReturnValueACollection
Does that assume a user has set the resultClass or resutlMap property? I think
its possible to have a statement node without a resultClass or resultMap
(assume the user table only has one record in it):
<statement id="GetOneOrMany" listClass="UserCollection">
SELECT * FROM user
</statement>
and call it using both list and object context:
sqlMapper.QueryForObject("GetOneOrMany", null);
sqlMapper.QueryForList("GetOneOrMany", null);
In ReflectionInfo.cs, I saw a comment about a Castle issue:
http://support.castleproject.org/jira//browse/DYNPROXY-8
Since that issue was marked as Won't Fix, will ReflectionInfo.cs function
correctly?
In LineItemCollection.cs why are Count, GetEnumerator, and RemoveAt marked as
virtual? Will there be problems if a user extends CollectionBase and _doesn't_
mark those methods as virtual?
Is there anyway you could generate a diff file for the changed classes? Its
helpful to see the old code vs the new code at the same time. A lot of people
use the TortoiseSVN client. You basically right click a file then choose
"Create Patch...":
http://tortoisesvn.tigris.org/
> Lazy load support for Strong typed collections and single Items
> ---------------------------------------------------------------
>
> Key: IBATISNET-105
> URL: http://issues.apache.org/jira/browse/IBATISNET-105
> Project: iBatis for .NET
> Type: New Feature
> Components: DataMapper, Testing
> Reporter: David Marzo
> Attachments: LazyLoad.zip, LazyLoad_rev.zip, LazyLoad_rev03.zip
>
> Nowadays Ibatis only support lazy load for no typed (IList) collections and
> can not lazy load relationship of 0 or 1.
> Changes:
> - In IBatisNet.DataMapper.Test.NUnit.SqlMapTests.ResultMapTest
> .TestLazyWithStronglyTypedCollectionMapping()
> exist one test that end ok but its outdated and it should fail.
> - BatisNet.DataMapper.Test.Domain.Order
> Ln 22:
> Original:
> private IList _lineItems;//LineItemCollection
> Correct:
> private LineItemCollection _lineItems;
> Ln: 50
> Original:
> public IList LineItems
> Correct:
> public LineItemCollection LineItems
> {...}
>
> In the statment order-with-lines-collection add to
> LazyLoad = "true"
> <resultMap id="order-with-lines-collection" class="Order"
> extends="lite-order-result-by-name" >
> <result property="LineItems" column="Order_ID"
> select="GetLineItemsForOrderWithListClass" lazyLoad="true"/>
> </resultMap>
> -TODO add test for 0...1 relationship , ej Worker.Boss
> Attached its the files changed to implement "beta" this feature
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
