[ http://issues.apache.org/jira/browse/IBATIS-167?page=comments#action_12366960 ]
Sven Boden commented on IBATIS-167: ----------------------------------- Anyone thoughts or objections against the changes in IBATIS-167. What I would change: - When pinging of the pool is enabled but no ping query is defined in the properties thrown an exception in initialize(). It's better to sink the "boat" in port than at open sea. If no exception is thrown problems would start occuring later on anyway. - In pingConnection(): When a connection check throws an exception include the message of the exception. When the ping query fails report the ping query and the corresponding SQL error message as log error, this should give most people who have this problem an "aha" feeling. - Change error message: "Error accessing SimplePooledConnection. Connection has been invalidated (probably released back to the pool)." Leave of the released back to the pool part... in most cases this explanation will be wrong and will cause confusion (as in IBATIS-158). I plan to check in the changes around February 24 unless someone reacts. Regards, Sven > Improvements in SimpleDataSource > -------------------------------- > > Key: IBATIS-167 > URL: http://issues.apache.org/jira/browse/IBATIS-167 > Project: iBatis for Java > Type: Improvement > Components: SQL Maps > Versions: 2.0.8, 2.0.9, 2.1.0, 2.0.9b > Environment: All > Reporter: Sven Boden > Priority: Trivial > Attachments: SimpleDataSource.java > > 1) With some small changes in SimpleDataSource problems as described in > IBATIS-158 would occurr much less. > 2) Requested by Clinton: "The biggest improvement I'd like to make is removal > of the exclusive > Properties based configuration. I'd rather have a JavaBean style API for > configuration, which could potentually use a Properties file still, but with > properties that match exact JavaBeans properties for configuration." -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
