[ http://issues.apache.org/jira/browse/IBATIS-264?page=comments#action_12367175 ]
Sven Boden commented on IBATIS-264: ----------------------------------- Currently the sql/include are pretty "static", so it's not really a peanut change. Your proposal takes care of 1 argument, how would you handle multiple arguments? Personally I don't see a huge benefit in the proposal the way I use includes now: 1) When including columns you can chose your table aliases so you can make sure different queries using the same columns use the same table aliases (in the <select> and in the <sql> snippet). And how many times are you going to have a situation in which you have the same columns in 2 different tables using different aliases. 2) When putting a query starting from the from part in an <sql> include and having different columns in different <select>s but including the same base query I also don't see a huge benefit for arguments. > Include with parameter > ---------------------- > > Key: IBATIS-264 > URL: http://issues.apache.org/jira/browse/IBATIS-264 > Project: iBatis for Java > Type: Improvement > Components: SQL Maps > Versions: 2.1.7 > Reporter: Nils Winkler > Priority: Minor > > I have the following problem: I include the same SQL snippet from > multiple select statements, some of them for completely unrelated > tables. This is done because these tables contain quite a few columns > with the same names in both tables. > <sql id="inc"> > name, > value, > foo, > bar > </sql> > <select id="loadA"> > select id, > <include refid="inc" /> > from A > </select> > <select id="loadB"> > select id, > <include refid="inc" /> > from B > </select> > When including the list of columns, it would be quite handy to add a > parameter to the include, for example to set a table alias in case I > have a join between tables: > <select id="loadA"> > select a.id, b.id, > <include refid="inc" /> > from A a > inner join B b on (b.id = a.id) > where b.baz = #baz# > </select> > In the above query, "name", "value" etc are no longer unique in the > query, most of the time you end up with the wrong values. > It would be great if I would be able to pass in a parameter to the > include, e.g.: > <select id="loadA"> > select a.id, b.id, > <include refid="inc" param="a."/> > from A a > inner join B b on (b.id = a.id) > where b.baz = #baz# > </select> > so I could have the SQL snippet defined like this: > <sql id="inc"> > $param$name, > $param$value, > $param$foo, > $param$bar > </sql> > This way, all of the statements would still work and I could make sure > that the correct columns are used in each case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
