mccheah commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240416792
##########
File path:
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -91,7 +91,7 @@ public TableMetadata refresh() {
}
this.version = ver;
this.currentMetadata = TableMetadataParser.read(this,
- HadoopInputFile.fromPath(metadataFile, conf));
+ fileIo().newInputFile(metadataFile.toString()));
Review comment:
You can, but then that requires subclasses of `HadoopTableOperations` to
also be returning an instance of `HadoopFileIO` also. I'd very much like to
keep everything returning the highest level of the abstraction as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
