+1 On Tue, Mar 5, 2019, 5:26 PM RD <rdsr...@gmail.com> wrote:
> +1 > > On Tue, Mar 5, 2019 at 5:01 PM John Zhuge <jzh...@apache.org> wrote: > >> +1 >> >> On Tue, Mar 5, 2019 at 4:59 PM Xabriel Collazo Mojica >> <xcoll...@adobe.com.invalid> wrote: >> >>> +1 >>> >>> >>> >>> *Xabriel J Collazo Mojica* | Senior Software Engineer | Adobe | >>> xcoll...@adobe.com >>> >>> >>> >>> *From: *Ted Gooch <tgo...@netflix.com.INVALID> >>> *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >>> *Date: *Tuesday, March 5, 2019 at 4:21 PM >>> *To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org> >>> *Cc: *Ryan Blue <b...@apache.org> >>> *Subject: *Re: [VOTE] Add the python implementation >>> >>> >>> >>> +1 >>> >>> >>> >>> On Tue, Mar 5, 2019 at 4:19 PM Ryan Blue <b...@apache.org> wrote: >>> >>> +1 >>> >>> >>> >>> On Tue, Mar 5, 2019 at 4:18 PM Ryan Blue <b...@apache.org> wrote: >>> >>> Hi everyone, >>> >>> >>> >>> I'd like to propose accepting the current Python PR, #54 >>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-iceberg%2Fpull%2F54&data=02%7C01%7Cxcollazo%40adobe.com%7C7ee0ecb319a24e73837808d6a1c9bbdd%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636874285150185399&sdata=pMSZpQ725aUC1TDd7P322i3KbsJYa6g8JdVkL0xtu8A%3D&reserved=0>. >>> It has been through a round of reviews and while there is certainly more to >>> do, it is going to be much easier to improve the implementation with >>> smaller pull requests than to keep updating one giant PR. >>> >>> >>> >>> As noted in the discussion thread, this will not be included in the >>> initial Java release. Also, the code would live in the existing repository >>> where we already have visibility, until we have a reason to move it >>> elsewhere. >>> >>> >>> >>> Please vote in the next 72 hours: >>> >>> >>> >>> [ ] +1: Commit the current Python PR implementation >>> >>> [ ] +0: . . . >>> >>> [ ] -1: Do not add the current implementation because . . . >>> >>> >>> >>> Thanks! >>> >>> >>> >>> rb >>> >>> >>> >>> -- >>> >>> Ryan Blue >>> >>> >>> >>> >>> -- >>> >>> Ryan Blue >>> >>> >> >> -- >> John Zhuge >> >
