Thanks for quick reply. I will wait for this to get merged to master and
will rebase after.


--
Thanks & Regards

On Tue, May 19, 2020 at 7:38 PM Junjie Chen <chenjunjied...@gmail.com>
wrote:

> Hi
>
> I think you need this fix:
> https://github.com/apache/incubator-iceberg/pull/1049.
>
> On Wed, May 20, 2020 at 10:25 AM Sud <sudssf2...@gmail.com> wrote:
>
>> I am trying to prepare pull request for review but looks like python
>> build is failing because of unrelated error.
>> I have seen some other build fail with this error too. any one knows how
>> to fix this issue?
>>
>> https://github.com/apache/incubator-iceberg/pull/1046
>> https://travis-ci.org/github/apache/incubator-iceberg/jobs/689057881
>>
>>
>> ___________________________ test_to_json_conversion 
>> ____________________________
>> 753
>> 754    def test_to_json_conversion():
>> 755        spec_schema = Schema(NestedField.required(1, "i", 
>> IntegerType.get()),
>> 756                             NestedField.required(2, "l", LongType.get()),
>> 757                             NestedField.required(3, "d", DateType.get()),
>> 758                             NestedField.required(4, "t", TimeType.get()),
>> 759                             NestedField.required(5, "ts", 
>> TimestampType.without_timezone()),
>> 760                             NestedField.required(6, "dec", 
>> DecimalType.of(9, 2)),
>> 761                             NestedField.required(7, "s", 
>> StringType.get()),
>> 762                             NestedField.required(8, "u", UUIDType.get()),
>> 763                             NestedField.required(9, "f", 
>> FixedType.of_length(3)),
>> 764                             NestedField.required(10, "b", 
>> BinaryType.get()))
>> 765
>> 766        specs = [
>> 767            PartitionSpec.builder_for(spec_schema).identity("i").build(),
>> 768            PartitionSpec.builder_for(spec_schema).identity("l").build(),
>> 769            PartitionSpec.builder_for(spec_schema).identity("d").build(),
>> 770            PartitionSpec.builder_for(spec_schema).identity("t").build(),
>> 771            PartitionSpec.builder_for(spec_schema).identity("ts").build(),
>> 772            
>> PartitionSpec.builder_for(spec_schema).identity("dec").build(),
>> 773            PartitionSpec.builder_for(spec_schema).identity("s").build(),
>> 774            PartitionSpec.builder_for(spec_schema).identity("u").build(),
>> 775            PartitionSpec.builder_for(spec_schema).identity("f").build(),
>> 776            PartitionSpec.builder_for(spec_schema).identity("b").build(),
>> 777            PartitionSpec.builder_for(spec_schema).bucket("i", 
>> 128).build(),
>> 778            PartitionSpec.builder_for(spec_schema).bucket("l", 
>> 128).build(),
>> 779            PartitionSpec.builder_for(spec_schema).bucket("d", 
>> 128).build(),
>> 780            PartitionSpec.builder_for(spec_schema).bucket("t", 
>> 128).build(),
>> 781            PartitionSpec.builder_for(spec_schema).bucket("ts", 
>> 128).build(),
>> 782            PartitionSpec.builder_for(spec_schema).bucket("dec", 
>> 128).build(),
>> 783            PartitionSpec.builder_for(spec_schema).bucket("s", 
>> 128).build(),
>> 784            PartitionSpec.builder_for(spec_schema).year("d").build(),
>> 785            PartitionSpec.builder_for(spec_schema).month("d").build(),
>> 786            PartitionSpec.builder_for(spec_schema).day("d").build(),
>> 787            PartitionSpec.builder_for(spec_schema).year("ts").build(),
>> 788            PartitionSpec.builder_for(spec_schema).month("ts").build(),
>> 789            PartitionSpec.builder_for(spec_schema).day("ts").build(),
>> 790            PartitionSpec.builder_for(spec_schema).hour("ts").build(),
>> 791            PartitionSpec.builder_for(spec_schema).truncate("i", 
>> 10).build(),
>> 792            PartitionSpec.builder_for(spec_schema).truncate("l", 
>> 10).build(),
>> 793            PartitionSpec.builder_for(spec_schema).truncate("dec", 
>> 10).build(),
>> 794            PartitionSpec.builder_for(spec_schema).truncate("s", 
>> 10).build(),
>> 795>           PartitionSpec.builder_for(spec_schema).add(6, "dec_bucket", 
>> "bucket[16]").build()
>> 796        ]
>> 797E       TypeError: add() missing 1 required positional argument: 
>> 'transform'
>> 798
>> 799tests/core/test_partition_spec.py:73: TypeError
>>
>>
>
> --
> Best Regards
>

Reply via email to