I now looked better and see that the Travis file does actually build
Iceberg ;) I'm still curious how something managed to get merged into
master while failing the tests though?

On Fri, 5 Jun 2020 at 13:13, Mass Dosage <[email protected]> wrote:

> Hello all,
>
> I just wanted to know if there is any CI set up for Iceberg? I noticed
> that if I pull the current master branch I get failing tests (see below for
> stack traces, Ryan - we talked about this last night but it's still
> happening). So this made me wonder why there isn't some CI set up to check
> that every PR actually successfully passes the build. I noticed there is a
> .travis.yml but this doesn't seem to run the gradle build. Should we add
> that or create a GitHub action to do this? I think it would be a really
> good safety net to have to reduce the likelihood of broken code and tests
> getting into master.
>
> Below are the two tests which are currently failing for me:
>
> > Task :iceberg-data:test
>
> org.apache.iceberg.data.TestLocalScan > testFilterWithDateAndTimestamp[1]
> FAILED
>     java.lang.AssertionError
>         at org.junit.Assert.fail(Assert.java:86)
>         at org.junit.Assert.assertTrue(Assert.java:41)
>         at org.junit.Assert.assertTrue(Assert.java:52)
>         at
> org.apache.iceberg.data.TestLocalScan.testFilterWithDateAndTimestamp(TestLocalScan.java:486)
>
> org.apache.iceberg.data.TestMetricsRowGroupFilterTypes > testEq[20] FAILED
>     java.lang.AssertionError: Should read: value is in the row group:
> 2018-06-29
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.assertTrue(Assert.java:41)
>         at
> org.apache.iceberg.data.TestMetricsRowGroupFilterTypes.testEq(TestMetricsRowGroupFilterTypes.java:284)
>
> 211 tests completed, 2 failed, 6 skipped
>
> > Task :iceberg-data:test FAILED
>
> Thanks,
>
> Adrian
>

Reply via email to