I think it's good to invite apache iceberg hive maintainers to evaluate whether this issue should be a blocker for 0.12.1. I'm okay for either.
On Wed, Oct 27, 2021 at 11:50 PM Ryan Blue <b...@tabular.io> wrote: > I'm not sure that #3393 is necessarily something that we should wait for. > If it gets in soon, I'd be all for including it. But there are some > important correctness fixes going into 0.12.1 for delete file commits and > I'd like to get those out as soon as possible. > > It looks like this bug affects Hive and is a failure, not a correctness > problem. I would probably opt to continue with 0.12.1 and follow up with > 0.12.2 once this is fixed if we think that it is affecting enough people > that a patch release is warranted. And if we don't think that a patch > release for this is needed, then I think that makes it less important to > get it into 0.12.1. > > What does everyone else think? Should we wait for this Hive fix? > > On Wed, Oct 27, 2021 at 3:17 AM OpenInx <open...@gmail.com> wrote: > >> I think we will need to fix this critical iceberg bug before we release >> the 0.12.1: https://github.com/apache/iceberg/issues/3393 . Let's mark >> it as a blocker for the 0.12.1. >> >> On Fri, Oct 22, 2021 at 3:22 AM Kyle Bendickson <k...@tabular.io> wrote: >> >>> Thank you everybody for the additional PRs brought up so far. >>> >>> I’ve volunteered to be release manager, so will be doing my best to go >>> through and ensure these are prioritized for consideration (if some are >>> truly new features they might need to wait for 0.13.0, but as I’m just the >>> release manager that will be mire up to the community). >>> >>> If any committers or contributors have free cycles and are willing to >>> review some of these PRs, that would be greatly appreciated! >>> >>> - Kyle Bendickson [@kbendick] >>> >>> On Thu, Oct 21, 2021 at 11:19 AM Peter Vary <pv...@cloudera.com.invalid> >>> wrote: >>> >>>> Just to make this clean https://github.com/apache/iceberg/pull/3338 fixes >>>> the issue caused by https://github.com/apache/iceberg/pull/2565. The >>>> fix will make Catalogs.loadCatalog consistent with Catalogs.hiveCatalog, >>>> and fixing create table issues when no catalog is set in the config >>>> >>>> On 2021. Oct 21., at 16:59, Peter Vary <pv...@cloudera.com> wrote: >>>> >>>> I would like to have this in 0.12.1: >>>> https://github.com/apache/iceberg/pull/3338 >>>> >>>> This breaks Hive queries, if no catalog is set, but this still needs to >>>> be reviewed before merge. >>>> >>>> Thanks, Peter >>>> >>>> >>>> On Thu, 21 Oct 2021, 07:12 Rajarshi Sarkar, <rsarkar...@gmail.com> >>>> wrote: >>>> >>>>> Hope this can get in: https://github.com/apache/iceberg/pull/3175 >>>>> >>>>> Regards, >>>>> Rajarshi Sarkar, >>>>> >>>>> >>>>> On Thu, Oct 21, 2021 at 9:08 AM Cheng Pan <cheng...@apache.org> wrote: >>>>> >>>>>> Hope this can get in. >>>>>> https://github.com/apache/iceberg/pull/3203 >>>>>> >>>>>> Thanks, >>>>>> Cheng Pan >>>>>> >>>>>> >>>>>> On Thu, Oct 21, 2021 at 11:34 AM Reo Lei <leinuo...@gmail.com> wrote: >>>>>> >>>>>>> Thanks Kyle for syncing this! >>>>>>> >>>>>>> I think PR#3240 should be include in this release. Because in our >>>>>>> Dingding group, we have received feedback from many flink users that >>>>>>> they >>>>>>> encountered this problem. I think this PR is very important and we need >>>>>>> to >>>>>>> fix this problem ASAP. >>>>>>> >>>>>>> link: https://github.com/apache/iceberg/pull/3240 >>>>>>> >>>>>>> BR, >>>>>>> Reo LEI >>>>>>> >>>>>>> Kyle Bendickson <k...@tabular.io> 于2021年10月21日周四 上午2:52写道： >>>>>>> >>>>>>>> As mentioned in today's community sync up, we're planning on >>>>>>>> releasing a new point version of Iceberg - Apache Iceberg 0.12.1. >>>>>>>> >>>>>>>> If there are any outstanding bugs you'd like to include fixes for >>>>>>>> or other minor patches, please respond to this email thread letting us >>>>>>>> know. >>>>>>>> >>>>>>>> The current list of patches to be included can be found in the >>>>>>>> milestone on Github: >>>>>>>> https://github.com/apache/iceberg/milestone/15?closed=1 >>>>>>>> >>>>>>>> As new items are added, they will be included in the milestone. >>>>>>>> >>>>>>>> Best, >>>>>>>> Kyle Bendickson [ Github: @kbendick ] >>>>>>>> >>>>>>> >>>> > > -- > Ryan Blue > Tabular >
