rdblue commented on code in PR #4427:
URL: https://github.com/apache/iceberg/pull/4427#discussion_r841281166
##########
core/src/main/java/org/apache/iceberg/util/Tasks.java:
##########
@@ -212,7 +212,9 @@ public boolean run(Task<I, RuntimeException> task) {
I item = iterator.next();
try {
runTaskWithRetry(task, item);
- succeeded.add(item);
+ if (revertTask != null) {
+ succeeded.add(item);
+ }
Review Comment:
This is very suspicious to me. Can you explain why `Tasks` needs to change?
It seems like this may be trying to handle the case where a revert happens
later and so the success didn't necessarily go through. But this check doesn't
look like the right way to accomplish that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
