rdblue commented on code in PR #4071: URL: https://github.com/apache/iceberg/pull/4071#discussion_r841294693
########## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.Map; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +class UpdateSnapshotReferencesOperation implements PendingUpdate<Map<String, SnapshotRef>> { + + private final TableOperations ops; + private final Map<String, SnapshotRef> updatedRefs; + private TableMetadata base; + + UpdateSnapshotReferencesOperation(TableOperations ops) { + this.ops = ops; + this.base = ops.current(); + this.updatedRefs = Maps.newHashMap(base.refs()); + } + + @Override + public Map<String, SnapshotRef> apply() { + return refDiff(base.refs(), updatedRefs); + } + + @Override + public void commit() { + TableMetadata updated = internalApply(); + ops.commit(base, updated); + } + + public UpdateSnapshotReferencesOperation createBranch(String name, long snapshotId) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + ValidationException.check(updatedRefs.get(name) == null, "Reference with name %s already exists", name); + SnapshotRef branch = SnapshotRef.branchBuilder(snapshotId).build(); + SnapshotRef existingRef = updatedRefs.put(name, branch); + ValidationException.check(existingRef == null, "Reference with name %s already exists", name); + return this; + } + + public UpdateSnapshotReferencesOperation createTag(String name, long snapshotId) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + ValidationException.check(updatedRefs.get(name) == null, "Reference with name %s already exists", name); + SnapshotRef tag = SnapshotRef.tagBuilder(snapshotId).build(); + SnapshotRef existingRef = updatedRefs.put(name, tag); + ValidationException.check(existingRef == null, "Reference with name %s already exists", name); + return this; + } + + public UpdateSnapshotReferencesOperation removeBranch(String name) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + SnapshotRef ref = updatedRefs.get(name); + ValidationException.check(ref != null, "No such branch with name %s", name); + ValidationException.check(ref.isBranch(), "Ref with name %s is a tag not a branch", name); + updatedRefs.remove(name); + return this; + } + + public UpdateSnapshotReferencesOperation removeTag(String name) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + SnapshotRef ref = updatedRefs.get(name); + ValidationException.check(ref != null, "No such tag with name %s", name); + ValidationException.check(ref.isTag(), "Ref with name %s is a branch not a tag", name); + updatedRefs.remove(name); + return this; + } + + public UpdateSnapshotReferencesOperation renameBranch(String name, String newName) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + Preconditions.checkNotNull(newName, "Branch name cannot be null"); + SnapshotRef ref = updatedRefs.get(name); + ValidationException.check(ref != null, "No such ref with name %s", name); + ValidationException.check(ref.isBranch(), "Ref with name %s is a tag not a branch", name); + updatedRefs.put(newName, ref); + updatedRefs.remove(name, ref); + return this; + } + + public UpdateSnapshotReferencesOperation replaceBranch(String name, long snapshotId) { Review Comment: I think replacing a branch with another is going to be common, so we may want to add a method for it. For example, people we talk to are planning to using branching and tagging to make changes, validate, and then commit them to main. That basically requires: 1. Create a branch from main 2. Commit to the branch 3. Validate the branch 4. Replace main with branch So I'd probably have a `replaceBranch(String, String)` operation. And I would also have a `fastForwardBranch(String, String)` that validates replacing the branch will not lose any commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
