amogh-jahagirdar commented on code in PR #4071: URL: https://github.com/apache/iceberg/pull/4071#discussion_r841386980
########## core/src/main/java/org/apache/iceberg/TableMetadata.java: ########## @@ -1007,6 +1007,49 @@ public Builder setBranchSnapshot(long snapshotId, String branch) { return this; } + public Builder setTag(String tag, SnapshotRef ref) { + SnapshotRef existingRef = refs.get(tag); + if (existingRef != null && existingRef.equals(ref)) { + return this; + } + long snapshotId = ref.snapshotId(); Review Comment: Ah my bad, I will make sure on the next iteration to cleanup any white space/newline I missed ########## core/src/main/java/org/apache/iceberg/TableMetadata.java: ########## @@ -1007,6 +1007,49 @@ public Builder setBranchSnapshot(long snapshotId, String branch) { return this; } + public Builder setTag(String tag, SnapshotRef ref) { + SnapshotRef existingRef = refs.get(tag); + if (existingRef != null && existingRef.equals(ref)) { + return this; + } + long snapshotId = ref.snapshotId(); Review Comment: Ah my bad, I will make sure on the next iteration to cleanup any white space/newline I missed from before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org