+1 The spec change makes sense. left a question in the PR.
On Sun, Feb 2, 2025 at 8:52 PM roryqi <[email protected]> wrote: > +1 > > Amogh Jahagirdar <[email protected]> 于2025年2月2日周日 10:16写道： > >> +1 >> >> On Sat, Feb 1, 2025 at 11:05 AM huaxin gao <[email protected]> >> wrote: >> >>> +1 (non-binding) >>> >>> On Sat, Feb 1, 2025 at 8:50 AM Manish Malhotra < >>> [email protected]> wrote: >>> >>>> +1(nonbinding) >>>> >>>> On Sat, Feb 1, 2025 at 2:49 AM Russell Spitzer < >>>> [email protected]> wrote: >>>> >>>>> +1 >>>>> >>>>> On Sat, Feb 1, 2025 at 3:01 AM Anton Okolnychyi <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> I propose the following updates to our partition stats spec in V3: >>>>>> >>>>>> - Modify `position_delete_record_count` to include a sum of position >>>>>> deletes across position delete files and DVs >>>>>> - Keep `position_delete_file_count` to represent the number of >>>>>> position delete files (ignoring DVs) >>>>>> - Add `dv_count` to represent the number of DVs >>>>>> - Make delete counts required to avoid ambiguity w.r.t NULL vs >>>>>> unknown. >>>>>> >>>>>> Here is the PR with the spec update: >>>>>> https://github.com/apache/iceberg/pull/12098 >>>>>> >>>>>> - Anton >>>>>> >>>>>
