+1 (non-binding). Build and tests passed on the following environment. I also verified that issues from RC0 and RC1 have been fixed. - Apple clang 21.0.0 (clang-2100.0.123.102) - CMake 4.3.3 - Ninja 1.13.2 - macOS arm64 Darwin 25.5.0
Thanks, Manu On Wed, Jun 10, 2026 at 10:54 AM Gang Wu <[email protected]> wrote: > Thanks Kevin for the suggestion! We already used the GitHub workflow [1] > to run the verification script in the release process and the result is > available at [2]. > > Regarding the issues Matt raised, I think they are more like thirdparty > dependency issues. We should improve our verify script to force CMake to > vendor all thirdparty libraries so they do not depend on the user's > environment. Vendoring libcurl is tricky, so I'm inclined to fail fast if > libcurl is missing or has an incompatible version. We can add an option to > skip verification of the rest catalog component if the user's environment > encounters trouble. That said, I don't think this should block the release > IMHO. > > [1] > https://github.com/apache/iceberg-cpp/blob/main/.github/workflows/rc.yml > [2] https://github.com/apache/iceberg-cpp/actions/runs/27195788895 > > Best, > Gang > > On Wed, Jun 10, 2026 at 10:36 AM Kevin Liu <[email protected]> wrote: > >> We can use github workflow to test out the verification script. The >> workflow run provides a clean workspace. Here's an example >> https://github.com/apache/datafusion-python/blob/main/.github/workflows/verify-release-candidate.yml >> >> You can test this by pushing the workflow definition to your fork's main >> branch and trigger it manually. >> >> >> On Tue, Jun 9, 2026 at 5:57 PM Matt Topol <[email protected]> wrote: >> >>> >>>> > The verify script requirements need to get updated: >>>> > >>>> > - meson is required but not listed >>>> >>>> meson is not required to run the verify script, we depend on cmake, they >>>> are two independent build systems and meson is not fully supported(e.g, >>>> meson doesn't support iceberg-bundle). >>>> >>> >>> If meson isn't supposed to be required, then something should change in >>> the verify script because cmake failed before it even got to building until >>> I installed meson. >>> >>> > - gtest/gmock are required but not listed >>>> >>>> googletest will automatically be made available by cmake's >>>> FetchContent, did >>>> you run into some problems? >>>> >>> >>> Cmake didn't do the fetch content by default then, it failed during >>> configure because it couldn't find gtest/gmock. After I installed them, I >>> could build. >>> >>> > - I had to export CPR_USE_SYSTEM_CURL=OFF for some reason due to ssl >>>> > stuff, unsure. >>>> >>>> I once met an issue that the system curl version is too low(something >>>> like curl >= 7.64.0 is required), may I know your >>>> installed curl version? We might need to specify the minimum curl >>>> version in the README. >>>> >>> >>> My system curl is 8.14.1 so this seems odd. I'll try recreating the >>> issue tomorrow and capture the exact error. >>> >>>>
