Hi all,

I'd like to ask for a review on https://github.com/apache/iceberg/pull/17464
(core/hive, opened Aug 1).

The fix: when a create commit fails before the table or view is ever
persisted, checkCurrentMetadataLocation is reached with null metadata and
throws an NPE, so the commit status check reports FAILURE instead of
UNKNOWN. A failed create is then not retried when it should be.

Review state: @uros-b left two rounds of comments, both addressed.
- 7105ad0 adds TestHiveViewCommits coverage for the create-view path
- 639bd29 adds TestHiveCommits.testThriftExceptionUnknownStateOnCreate-
  CommitWhenTableNeverPersisted, driving a failed create through the real
  HiveTableOperations
Both tests fail on main without the fix. CI is green.

There has been no activity since Aug 19, so the PR will be marked stale
shortly. A duplicate of the same fix (#17548) was opened separately and is
now going stale as well.

Would a committer be able to take a look?

Thanks,
superdiaodiao

Reply via email to