GitHub user mlevkov added a comment to the discussion: Proposal: Generic HTTP Sink Connector
The branch has 9 commits (our 8 original + 1 new integration test commit).
Here's the final summary:
PR #2925 — 9 commits total:
─────────────────────────────────┐
│ # │ Commit │ Description
│
─────────────────────────────────
│ 1 │ 1f485613 │ Scaffold HTTP sink connector with types and stub Sink impl
─────────────────────────────────
│ 2 │ 9554d193 │ Implement HTTP sink core — consume, retry, batch modes
─────────────────────────────────
│ 3 │ 810828f9 │ Remediate 12 review findings (CR round 1)
─────────────────────────────────
│ 4 │ ba236eb2 │ Remediate 7 follow-up review findings (CR round 2)
─────────────────────────────────
│ 5 │ 81036b01 │ Add HTTP sink example config.toml
─────────────────────────────────
│ 6 │ c4d02586 │ Add HTTP sink README with usage, config reference, known
limitations
─────────────────────────────────
│ 7 │ f23ce561 │ Add 46 unit tests for HTTP sink connector
─────────────────────────────────
│ 8 │ bd5fca68 │ Address 5 test/docs review findings
─────────────────────────────────
│ 9 │ 82d43ad9 │ Add 6 integration tests using WireMock
─────────────────────────────────┘
Test coverage: 47 unit tests + 6 integration tests = 53 total
Integration tests cover:
- Individual mode: 3 JSON messages → 3 separate POST requests with metadata
envelope
- NDJSON mode: 3 messages → 1 POST with newline-delimited JSON body
- JSON array mode: 3 messages → 1 POST with JSON array body
- Raw mode: 3 binary messages → 3 POSTs with application/octet-stream, no
envelope
- Metadata disabled: verify bare payload without wrapper
- Sequential offsets: 5 messages verify contiguous offset ordering in
metadata
All artifacts:
- PR: https://github.com/apache/iggy/pull/2925
- Issue #2927: consume() return value discarded
- Issue #2928: PollingMessages commits before processing
- Discussion: https://github.com/apache/iggy/discussions/2919
GitHub link:
https://github.com/apache/iggy/discussions/2919#discussioncomment-16106605
----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]
