GitHub user hubcio added a comment to the discussion: send_messages should return base_offset and partition_id
hi, thanks for continuing under discussion. reference issue: #3038 a few comments from my side: - we are fine with returning base_offset from SendMessages command. - we have #3041 in flight which rewires the entire binary protocol layer - ShardResponse, handler dispatch, wire types, BytesSerializable removal. the code paths you'd touch (ShardResponse::SendMessages, send_messages_handler, shard execution) are all being rewritten there. please wait until its merged. - about backwards compatibility - you might be right, however make sure that all other SDKs have it handled. it has to be delivered under single PR. code that is merged to master has to be working for all SDKs - this is how we manage feature parity. - partition_id - yes, it should be included - sdk trait: prefer something like Option<AppendInfo> instead of sentinel valiues like u32::MAX GitHub link: https://github.com/apache/iggy/discussions/3044#discussioncomment-16376751 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
