Hi Romain, The implementation I have in mind won't be costly. I'm working on it this week.
I still don't agree with a ClassLoaderCodec SPI as-is. If we create an SPI it should be for more generic hinting applicable in other circumstances during serialisation with other frameworks and what not. Otherwise, we should not create a pluggable SPI at all and simply implement an option. As a matter of fact, with the last solution I proposed I don't think there will be any edge cases at all where users would need to create their own "ClassLoaderCodec" at all. Regards, *Raúl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani http://blog.raulkr.net | twitter: @raulvk On Tue, Nov 10, 2015 at 3:06 PM, Romain Gilles <[email protected]> wrote: > To be honest Raoul, I'm more interesting in the interface (SPI) declaration > than the implementation. If you can do it for the 1.5 I'm ok. Otherwise I > ready to start it by introducing the interface and implementing the dummy > version for non OSGi environment. > > It will free me to implement a temporary OSGi version by the time you are > done with the overall IGNITE-1270 tasks. > > Thanks, > > Romain > > Le mar. 10 nov. 2015 à 15:42, Raul Kripalani <[email protected]> a écrit : > > > Hi Romain, > > > > If you don't mind, I'm working on the entire OSGi integration including > the > > serialisation technique. > > > > I'll ping you if I need help. > > > > Thanks for your collaboration, > > > > *Raúl Kripalani* > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and > > Messaging Engineer > > http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani > > http://blog.raulkr.net | twitter: @raulvk > > > > On Tue, Nov 10, 2015 at 1:50 PM, Romain Gilles <[email protected]> > > wrote: > > > > > Hi, > > > I have put my comments. Hope they will make the things progress :) > > > Should I start to implement this ticket or should I wait and see if > Raoul > > > want to take it? > > > > > > Romain > > > > > > Le mar. 10 nov. 2015 à 02:58, Dmitriy Setrakyan <[email protected] > > > > a > > > écrit : > > > > > > > Thanks Raul, great points! I have created a ticket for the > > > > class-loader-detection design, described on wiki: > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-1877 > > > > > > > > D. > > > > > > > > On Mon, Nov 9, 2015 at 3:42 PM, Raul Kripalani <[email protected]> > > wrote: > > > > > > > > > Hey Romain, > > > > > > > > > > I've updated the design proposal in the Wiki with my input. Could > you > > > > > please have a look and let me know what you think? > > > > > > > > > > I'll implement a proof of concept of my proposed > > > > marshalling/unmarshalling > > > > > strategy and push it to Git so you can take it for a spin. > > > > > > > > > > Regards, > > > > > > > > > > *Raúl Kripalani* > > > > > PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big > Data > > > and > > > > > Messaging Engineer > > > > > http://about.me/raulkripalani | > > > http://www.linkedin.com/in/raulkripalani > > > > > http://blog.raulkr.net | twitter: @raulvk > > > > > > > > > > On Fri, Nov 6, 2015 at 4:05 PM, Romain Gilles < > > [email protected] > > > > > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > I will put some sample code this WE. I'm exhausted sorry for the > > > > delay... > > > > > > Romain > > > > > > > > > > > > Le ven. 6 nov. 2015 à 00:45, Andrey Kornev < > > [email protected] > > > > > > > > a > > > > > > écrit : > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > We've made an attempt to formalize the approach to Ignite's > OSGi > > > > > > > enablement: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/OSGI+Compatibility. > > > > > > > Please have a look and feel free to provide your positive > > feedback > > > > :))) > > > > > > > > > > > > > > Thanks > > > > > > > Andrey > > > > > > > > > > > > > > > From: [email protected] > > > > > > > > Date: Wed, 4 Nov 2015 09:26:17 -0800 > > > > > > > > Subject: Re: OSGi migration may require a special marshaller > > > > > > > > To: [email protected] > > > > > > > > > > > > > > > > On Wed, Nov 4, 2015 at 9:07 AM, Romain Gilles < > > > > > [email protected] > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi Dmitriy, > > > > > > > > > I found this post that explain how to find a bundle based > on > > > its > > > > > > bundle > > > > > > > > > name and version. > > > > > > > > > This post explain for the past to now how to do it in the > > > > standard > > > > > > way > > > > > > > with > > > > > > > > > "pull" approach: > > > > > https://www.eclipse.org/forums/index.php/t/205719/ > > > > > > > > > Regarding the version of OSGi you want to support then some > > > > > solutions > > > > > > > will > > > > > > > > > works some others will not. > > > > > > > > > There is an other way to do this stuff without using those > > > "pull" > > > > > > style > > > > > > > > > approach based on BundleTracker. If you want I can give you > > the > > > > > code > > > > > > > to do > > > > > > > > > it with BundlTracker. I think with this solution you will > > > > support a > > > > > > > wider > > > > > > > > > range of OSGi version. > > > > > > > > > > > > > > > > > > > > > > > > > Romain, if you can provide a generic code sample to look up a > > > > > > ClassLoader > > > > > > > > in OSGI based on manifest properties, would be great. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
