Thank you! Thanks, kcheng
On Thu, Feb 4, 2016 at 9:38 PM, Denis Magda <dma...@gridgain.com> wrote: > Hi Ken, > > Thanks for the contribution. Someone of the committers will review your > changes soon. > > -- > Denis > > > On 2/3/2016 5:34 PM, Ken Cheng wrote: > >> Sorry, my fault I forget to add the new junit to test suit. I committed >> again. >> >> Thanks, >> kcheng >> >> On Wed, Feb 3, 2016 at 10:17 PM, Ken Cheng <kcheng....@gmail.com> wrote: >> >> Hi All, >>> >>> For this PR, I added a new Junit test file file, but I found it's not >>> executed from TeamCity build log. >>> >>> How to add this new file to test suit? >>> >>> Thanks, >>> kcheng >>> >>> On Wed, Feb 3, 2016 at 8:41 PM, Ken Cheng <kcheng....@gmail.com> wrote: >>> >>> Hi Andrey Gura, >>>> >>>> Please help do a code review. >>>> All related test cases passed without break. >>>> >>>> >>>> >>>> http://204.14.53.151/viewLog.html?buildId=107343&tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteDataGrid >>>> >>>> Thanks, >>>> kcheng >>>> >>>> On Wed, Feb 3, 2016 at 7:47 PM, Ken Cheng <kcheng....@gmail.com> wrote: >>>> >>>> Here is the PR https://github.com/apache/ignite/pull/449 >>>>> >>>>> Please help to review it. >>>>> >>>>> Thanks, >>>>> kcheng >>>>> >>>>> On Wed, Feb 3, 2016 at 7:45 PM, Ken Cheng <kcheng....@gmail.com> >>>>> wrote: >>>>> >>>>> Yes, that's Andrey's proposal. >>>>>> >>>>>> I created the PR, right now it's run Tests. >>>>>> >>>>>> Thanks, >>>>>> kcheng >>>>>> >>>>>> On Wed, Feb 3, 2016 at 6:34 PM, Alexey Goncharuk < >>>>>> alexey.goncha...@gmail.com> wrote: >>>>>> >>>>>> +1 for printing out a warning and ignoring the affinity function from >>>>>>> the >>>>>>> configuration. There is no other way to 'fix' the configuration other >>>>>>> than >>>>>>> remove the wrong affinity function, so it can be done at startup time >>>>>>> right >>>>>>> away. >>>>>>> >>>>>>> 2016-02-03 9:43 GMT+03:00 Ken Cheng <kcheng....@gmail.com>: >>>>>>> >>>>>>> I prefer to throw a IgniteCheckerException. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> kcheng >>>>>>>> >>>>>>>> On Wed, Feb 3, 2016 at 2:41 PM, Ken Cheng <kcheng....@gmail.com> >>>>>>>> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi Andrey Gura, >>>>>>>>> >>>>>>>>> >>>>>>>>> What's the expected behavior when the cache mode is "Local" but >>>>>>>>> >>>>>>>> affinity >>>>>>> >>>>>>>> function is not "LocalAffinityFunction"? >>>>>>>>> >>>>>>>>> 1: Throw an exception? >>>>>>>>> 2: or change the affinity function rudely as >>>>>>>>> >>>>>>>> "LocalAffinityFunction" and >>>>>>> >>>>>>>> log the warning message at same time? >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> kcheng >>>>>>>>> >>>>>>>>> On Wed, Feb 3, 2016 at 10:35 AM, Ken Cheng <kcheng....@gmail.com> >>>>>>>>> >>>>>>>> wrote: >>>>>>> >>>>>>>> Hi Andrey Gura, >>>>>>>>>> >>>>>>>>>> Thank you very much! I would study this part of code first. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> kcheng >>>>>>>>>> >>>>>>>>>> On Mon, Feb 1, 2016 at 6:37 PM, Andrey Gura <ag...@gridgain.com> >>>>>>>>>> >>>>>>>>> wrote: >>>>>>> >>>>>>>> Ken, >>>>>>>>>>> >>>>>>>>>>> cache configuration validation and initialization occurs in >>>>>>>>>>> GridCacheProcessor class (methods validate() and initialize()). >>>>>>>>>>> >>>>>>>>>>> From my point of view two changes should be made: >>>>>>>>>>> >>>>>>>>>>> - during cache intialization LocalAffinityFunction should be set >>>>>>>>>>> >>>>>>>>>> to >>>>>>> >>>>>>>> cache >>>>>>>> >>>>>>>>> configuration if cache mode is LOCAL; >>>>>>>>>>> - warning about ignoring affinity function parameter should be >>>>>>>>>>> >>>>>>>>>> moved >>>>>>> >>>>>>>> from >>>>>>>> >>>>>>>>> validate() method to intialize() method. >>>>>>>>>>> >>>>>>>>>>> I hope this will help you. >>>>>>>>>>> >>>>>>>>>>> On Mon, Feb 1, 2016 at 12:12 PM, Ken Cheng <kcheng....@gmail.com >>>>>>>>>>> >>>>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Andrey Gura, >>>>>>>>>>>> >>>>>>>>>>>> I am very new to Ignite, I am going to pick up >>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-1481. >>>>>>>>>>>> >>>>>>>>>>>> Can you please give more hint? >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> kcheng >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Andrey Gura >>>>>>>>>>> GridGain Systems, Inc. >>>>>>>>>>> www.gridgain.com >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>> >
