Hi all,
1) To run your pull request click "..." to the right of "Run" and chose
Changes -> Default Branch -> pull/961/head
2) Parent pom version is 1 because it was stable solution while project
grew extremely fast.
I see no restrictions to change it, but we have to theck it works, twice.
We need to check all tests works, then we'll need to make Test Release to
check nothing broken at deployment.
On Thu, Aug 18, 2016 at 3:25 AM, Igor Rudyak <irud...@gmail.com> wrote:
> Not sure about the original reason to fix version of parent POM.
>
> However the approach you proposed has one drawback comparing to
> ${app.version} approach. We again need to copy-paste new parent version
> number into all module POMs when start working on the next version.
>
> Here is more details:
>
> 1) Each module POM has such reference to parent:
>
> * <parent>*
> * <groupId>org.apache.ignite</groupId>*
> * <artifactId>ignite-parent</artifactId>*
> * <version>1</version>*
> * <relativePath>../parent</relativePath>*
> * </parent>*
>
> 2) The main problem here is in *<version>* tag, where you need to specify
> parent project version
>
> 3) Thus if you are going to change parent version number you need to
> copy-paste this number into ALL other POMs.
>
> 4) While using ${app.version} property defined in parent POM, you can just
> reuse such common peace of configuration in all other POMs:
>
> *<parent>*
> * <groupId>org.apache.ignite</groupId>*
> * <artifactId>ignite-parent</artifactId>*
> * <version>1</version>*
> * <relativePath>../parent</relativePath>*
> * </parent>*
>
> * <artifactId>my-module</artifactId>*
> * <version>${app.version}</version>*
> 5) Such a way, if you want switch to development of next version - you just
> need to change ${app.version} property in parent POM and it will be
> automatically "reused" by all other POMs. The benefit here is that we need
> to change version number only in one place.
>
>
> Igor Rudyak
>
>
> On Wed, Aug 17, 2016 at 4:13 PM, Raul Kripalani <r...@evosent.com> wrote:
>
> > On Wed, Aug 17, 2016 at 11:14 PM, Igor Rudyak <irud...@gmail.com> wrote:
> >
> > > It's not the solution in this case, cause parent version is always "1"
> > >
> >
> > What's the reason we've chosen to handle the hierarchy differently to
> most
> > other projects out there? Have we considered versioning the parent POM?
> > Doesn't a fixed 1 imply that it never evolves?
> >
> > Releasing the parent POM would also allow folks to create Ignite modules
> > without forking the entire project, just by referencing a parent POM that
> > is in Maven Central.
> >
> > Proposal: Set the project version in the parent POM and release it. All
> > children modules that inherit the parent will automatically inherit the
> > project version. Then we can forgo the ${app.version} property – which
> > quite frankly appears to be a code smell.
> >
> > Cheers.
> >
> > ---
> > Raúl Kripalani
> > linkedin.com/in/raulkripalani | evosent.com
> > <http://evosent.com/?utm_source=email&utm_medium=email&;
> > utm_campaign=evosent_raul>
> > | blog: raul.io
> > <http://raul.io?utm_source=email&utm_medium=email&utm_
> > campaign=evosent_raul> |
> > skype: raul.fuse
> >
>
