On Fri, Jan 27, 2017 at 8:51 PM, Alexander Paschenko < alexander.a.pasche...@gmail.com> wrote:
> Guys, > > And what would you say if I suggested that we implement custom grammar > support with ANTLR? It allows you to describe pretty much any grammar > in a declarative way, generates lexer and parser and then allows to > easily process parsed commands by implementing few (generated) > interfaces. Yesterday I gave it a try and it's really simple. > Downsides are use of generated code itself (I'm pretty sure someone is > strongly against it) and relative wordiness of resulting code written > manually. But this approach will no doubt save time and allow any > extensions or changes in syntax in the future w/o worrying about H2 or > anyone 3rd party. Thoughts? > > Alex, My preference would be to keep it simple, without introducing any custom grammar, at least for the "CREATE INDEX" command. I understand the need for decoupling cache from schema, but it will take much longer to implement, and I would leave it for phase 2. In phase 1 we can focus on delivering this much needed feature to the community as soon as possible. Do you agree? > - Alex > > 2017-01-27 21:56 GMT+03:00 Vladimir Ozerov <voze...@gridgain.com>: > > My point was that we can avoid dependency on 3rd party developers for > this > > relatively simple logic. > > > > On Fri, Jan 27, 2017 at 8:07 PM, Dmitriy Setrakyan < > dsetrak...@apache.org> > > wrote: > > > >> On Fri, Jan 27, 2017 at 5:45 AM, Sergi Vladykin < > sergi.vlady...@gmail.com> > >> wrote: > >> > >> > H2 to some extent supports syntax (and quirks) from other databases. > For > >> > example you can start it with MODE=MySQL and it will allow some MySQL > >> > specific syntax to be handled. > >> > > >> > Having said that, IMO the most correct way to handle non-standard > syntax > >> is > >> > to introduce H2 MODE=ApacheIgnite and put the needed switches there. > >> > > >> > Though this needs to be negotiated with H2 folks. > >> > > >> > >> Sergi, can you ask the H2 folks about this? I agree, this sounds like > the > >> most correct way. > >> >
