Hi Semyon! I've seen all fixes abut hibernate5 in ignite-3477-master. Will you finish this issue?
Vadim Opolski 2017-04-11 19:54 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>: > Hi Vadim, > > I already fixed all issues with hibernate5 tests and merged in > ignite-3477-master, it will be merged in master soon. > > Thanks > > On Tue, Apr 11, 2017 at 7:51 PM, Вадим Опольский <vaopols...@gmail.com> > wrote: > > > Hello guys! > > > > I added folder hibernate5 as module to project settings and discovered > some > > errors. Fixed errors in pull request - > > https://github.com/vopolski/ignite/pull/1/files > > But some tests from hibernate5 is failed. I'll fix them. > > > > How much time do I have? > > > > Vadim Opolski > > > > 2017-04-06 13:04 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>: > > > > > Dear sirs! > > > > > > Sorry for incorrect subject. > > > > > > https://github.com/apache/ignite/pull/1643 > > > > > > ---------- Forwarded message ---------- > > > From: Вадим Опольский <vaopols...@gmail.com> > > > Date: 2017-03-24 15:48 GMT+03:00 > > > Subject: ready for review IGNITE-933 > > > To: dev@ignite.apache.org, Denis Magda <dma...@apache.org>, Valentin > > > Kulichenko <valentin.kuliche...@gmail.com> > > > > > > > > > Hello everyone! > > > > > > Denis, Valentin, what should I do to close issue > > > https://issues.apache.org/jira/browse/IGNITE-1794 ? > > > > > > The tests in Team City executed successfully. > > > > > > Valentin, I renamed IgniteHibernateTestSuite -> > > IgniteHibernate5TestSuite. > > > Can you create TeamCity Configuration ? > > > > > > > > > > > > Vadim Opolski > > > > > > 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>: > > > > > >> Hello everybody. > > >> > > >> The issue https://issues.apache.org/jira/browse/IGNITE-1794 fixed > > >> originally by Mykola Pereyma. > > >> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 > > on > > >> myself, because we haven’t got a note from him for a while. > > >> > > >> Denis, I merged pull request https://github.com/apache/ > ignite/pull/1146 > > with > > >> my fork. > > >> Then I changed hibernate version to 5.2.7 and deleted > ByteArrayType.java > > >> as per CI comments. > > >> The tests from list below executed succesfully. > > >> > > >> Prepared new pull request - https://github.com/apache/ > ignite/pull/1643 > > >> > > >> What's the next step ? > > >> > > >> Tests: > > >> HibernateL2CacheConfigurationSelfTest.java > > >> HibernateL2CacheSelfTest.java > > >> HibernateL2CacheTransactionalSelfTest.java > > >> HibernateL2CacheTransactionalUseSyncSelfTest.java > > >> CacheHibernateBlobStoreNodeRestartTest.java > > >> CacheHibernateBlobStoreSelfTest.java > > >> CacheHibernateStoreFactorySelfTest.java > > >> CacheHibernateStoreSessionListenerSelfTest.java > > >> > > >> > > >> Vadim Opolski > > >> > > >> > > >> 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org>: > > >> > > >>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 > > is > > >>> interesting for me. How I can assignee it to me? It is assigning with > > >>> Mykola Pereyma now. > > >>> > > > >>> > https://issues.apache.org/jira/browse/IGNITE-1794 < > > >>> https://issues.apache.org/jira/browse/IGNITE-1794> > > >>> > > >>> Just re-assign it on yourself ;) Hope that Mykola is fine with this > > >>> because we haven’t got a note from him for a while. > > >>> > > >>> — > > >>> Denis > > >>> > > >>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский < > vaopols...@gmail.com> > > >>> wrote: > > >>> > > > >>> > Hi Denis, > > >>> > > > >>> > OK, I spotted the problem in the code and I will be try to resolve > > it. > > >>> > > > >>> > https://issues.apache.org/jira/browse/IGNITE-933 < > > >>> https://issues.apache.org/jira/browse/IGNITE-933> > > >>> > > > >>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 > > is > > >>> interesting for me. How I can assignee it to me? It is assigning with > > >>> Mykola Pereyma now. > > >>> > > > >>> > https://issues.apache.org/jira/browse/IGNITE-1794 < > > >>> https://issues.apache.org/jira/browse/IGNITE-1794> > > >>> > > > >>> > Vadim Opolski > > >>> > > > >>> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org <mailto: > > >>> dma...@apache.org>>: > > >>> > Hi Vadim, > > >>> > > > >>> > Yes, this issue might be still relevant. I can’t guide you through > > >>> but, basically, you need to reproduce the issue, spot it in the code > > and > > >>> propose a fix. > > >>> > > > >>> > BTW, do you have any experience with Hibernate? If so, I would be > > >>> amazing if you pick up this ticket reassigning on yourself: > > >>> > https://issues.apache.org/jira/browse/IGNITE-1794 < > > >>> https://issues.apache.org/jira/browse/IGNITE-1794> < > > >>> https://issues.apache.org/jira/browse/IGNITE-1794 < > > >>> https://issues.apache.org/jira/browse/IGNITE-1794>> > > >>> > > > >>> > — > > >>> > Denis > > >>> > > > >>> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский < > vaopols...@gmail.com > > >>> <mailto:vaopols...@gmail.com>> wrote: > > >>> > > > > >>> > > Dear sirs ! > > >>> > > > > >>> > > I want to resolve issue IGNITE-933 > > >>> > > > > >>> > > https://issues.apache.org/jira/browse/IGNITE-933 < > > >>> https://issues.apache.org/jira/browse/IGNITE-933> > > >>> > > > > >>> > > Is it actual ? > > >>> > > > > >>> > > In which class and method you want me to make changes ? > > >>> > > > > >>> > > Vadim Opolski > > >>> > > > >>> > > > >>> > > >>> > > >> > > > > > > > > >
