Vyacheslav, all three viewReadOnly methods have many usages.
And yes, some methods/classes were removed from GridFunc during other tasks. On Wed, Apr 12, 2017 at 7:24 PM, Vyacheslav Daradur <daradu...@gmail.com> wrote: > Andrey, > > I see you've merged it before I fixed merge conflict and you fixed it > yourself, thank you) > > There is one more unused method: > public static <K0, K extends K0, V0, V extends V0, V1> Map<K, V1> > viewReadOnly > > You can see it in my fixed version: > https://github.com/apache/ignite/pull/1652/files > > BTW, looks unusually that the master-branch contains separate commits of > this task. > > > 2017-04-12 19:13 GMT+03:00 Andrey Gura <ag...@apache.org>: > >> Vyacheslav, >> >> thank you for contribution! Your changes are merged into master branch. >> >> On Mon, Mar 20, 2017 at 1:11 PM, Vyacheslav Daradur <daradu...@gmail.com> >> wrote: >> > I've received answers in the issue. >> > >> > Ready for review. >> > >> > 2017-03-16 10:14 GMT+03:00 Vyacheslav Daradur <daradu...@gmail.com>: >> > >> >> Hello everyone. >> >> >> >> I have some questions about the issue https://issues.apache. >> >> org/jira/browse/IGNITE-3682 >> >> >> >> 1) Can I do some minor refactoring of GridFunc class within this task? >> >> (to remove unused methods and code duplicates) >> >> Or just to extract anonymous classes? >> >> >> >> 2) Should @Depricated be added to GridFunc and F classes? >> >> >> >> -- >> >> Best Regards, Vyacheslav >> >> >> > >> > >> > >> > -- >> > Best Regards, Vyacheslav >> > > > > -- > Best Regards, Vyacheslav
