Vladimir, I’m fully for your idea. In general, as soon as our DDL becomes mature enough we might want to simplify or get rid off current APIs that define SQL schema.
— Denis > On Apr 19, 2017, at 1:22 PM, Vladimir Ozerov <[email protected]> wrote: > > Igniters, > > I'd like to propose to deprecate infamous CacheConfiguration.setIndexedTypes > method. It has subtle semantics and clashes with > CacheConfiguration.setQueryEntities method. Several examples. > > Example 1 > setIndexedTypes(Key1.class, Value1.class); > setIndexedTypes(Key2.class, Value2.class); > => exeption > > Example 2 > setIndexedTypes(Key1.class, Value1.class); > setQueryEntitities(new QueryEntity(...)); > => all ok, two query entities > > Proposal: > 1) Deprecate CacheConfiguration.setIndexedTypes > 2) Add new constructor QueryEntity(Class keyCls, Class valCls) > 3) Remove all non-obvious semanrics from > CacheConfiguration.setQueryEntities method > and make it plain setter. > > Thoughts?
