Hi guys! Nikolay, the next improvements are maden ( https://github.com/apache/ignite/pull/1783):
- changed code according with code style (extra space, if else blocks, javadoc) - written two tests one which will testing new parametes and other which will testing role validation - used PowerMock framework to getRole getUser testing - ridden #setEnv method I did not test this parameters on real mesos cluster. Nikolay, I dont work with Mesos and think that anyone who has experience should make it. OK? Vadim Opolski 2017-04-19 17:01 GMT+03:00 Nikolay Tikhonov (JIRA) <j...@apache.org>: > > [ https://issues.apache.org/jira/browse/IGNITE-4052?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=15974725#comment-15974725 ] > > Nikolay Tikhonov commented on IGNITE-4052: > ------------------------------------------ > > [~javaller] > I've looked at changes and have minor comments: > * code style (extra space, if esle blocks, javadoc and etc. > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute); > * let's split #testIgniteFramework() test: one which will testing new > parametes and other which will testing role validation; > * let's to use PowerMock in test (distributed under apache 2.0 licence > which acceptable for our product) and rid #setEnv method; > > And again, did you test this parameters on real mesos cluster? > > Thank you for your contribution. > > > Add ability to set up users for MESOS > > ------------------------------------- > > > > Key: IGNITE-4052 > > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > > Project: Ignite > > Issue Type: Improvement > > Components: general > > Affects Versions: 1.7 > > Reporter: Nikolay Tikhonov > > Assignee: Vadim Opolski > > Priority: Trivial > > > > In current implementation Ignite Mesos Framework connects to MESOS > cluster via current user. Need to add ability to configure this parameters > via system env properties. Also need to add properties for mesos role. > > See org/apache/ignite/mesos/IgniteFramework.java:537 > > > > -- > This message was sent by Atlassian JIRA > (v6.3.15#6346) >
