Hi Nick! Good catch. Please go ahead and submit a patch.

--Yakov

2017-05-26 13:09 GMT+03:00 Николай Ижиков <nizhikov....@gmail.com>:

> Hello, guys.
>
> public interface DiscoverySpi extends IgniteSpi {
> ....
>     TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
>
>     TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
> ...
> }
>
> Two methods of DiscoverySpi returns concrete implementation.
> I think we should return interface, not implementation from this methods
> Or why we need an interface?
>
> I can provide simple patch to fix this issue.
>
> --
> Nikolay Izhikov
> nizhikov....@gmail.com
>

Reply via email to