Wow, hold on - as far as I remember there was a VOTE to accept the contribution of the code into the project _on a branch_. We haven't vetted its inclusion into the next release, We are still at the phase of getting familiar with the code.
And from what I am seeing in the discussions like this [1], we need to be extra careful. BTW, you have sent this email 9 days before the vote had happened! A bit too soon, if you ask me. [1] https://is.gd/UQCr51 Cos On Wed, May 17, 2017 at 11:16AM, Dmitriy Govorukhin wrote: > Folk, > > As you know, ignite 2.1 will contain new module (pds), it will be > provide ability to store data on disk. Let's discuss what type of > metrics we need for this? > I think it must be metrics per memory policy, per cache, checkpoint, > and global metrics which will be aggregate all metrics. > > I did sketch. > > PersistentStoreMetrics.java > > public interface PersistentStoreMetrics { > > // Global metrics. > > public long getMemorySize(); > > public long getDiskSize(); > > public long getPagesInMemory(); > > public long getPagesSizeInMemory(); > > public long getPagesOnDisk(); > > public long getPagesSizeOnDisk(); > > public long getFreePages(); > > public long getFreePagesSize(); > > public long getDirtyPages(); > > public long getDirtyPagesSize(); > > public long walLog(); > > public long walLogSize(); > > // Frequency. > > public long getPagesRead(); > > public long getPagesWrite(); > > public long getFsync(); > > public long getWal(); > > public long getAverageWalFsyncTime(); > > // Per cache. > > public PersistentStoreCacheMetrics cache(String name); > > public PersistentStoreCacheMetrics cache(int cacheId); > > // For last checkpoint. > > public PersistentStoreCheckpointMetrics getLastCheckPoint(); > } > > >>>>>>>>>>>>>>>>>>>>>>> > > PersistentStoreCacheMetrics.java > > public interface PersistentStoreCacheMetrics { > > public String name(); > > public double getFillFactor(); > > public double getFillFactor(int part); > > public long getMemorySize(); > > public long getDiskSize(); > > public long getPagesInMemory(); > > public long getPagesSizeInMemory(); > > public long getPagesOnDisk(); > > public long getPagesSizeOnDisk(); > > public long getFreePages(); > > public long getFreePagesSize(); > > public long getDirtyPages(); > > public long getDirtyPagesSize(); > > public long getPagesRead(); > > public long getPagesWritten(); > } > > >>>>>>>>>>>>>>>>>>>>>>> > > PersistentStoreCheckpointMetrics.java > > public interface PersistentStoreCheckpointMetrics { > > public long getTotalPages(); > > //TODO Page type is internal? > public long[] pagesType(); > > public long getExecutingTime(); > > public long getFsyncTime(); > > public long getPagesCopyOnWrite(); > }
