On Wed, Oct 11, 2017 at 7:44 AM, Иван Федотов <ivanan...@gmail.com> wrote:
> Hello, Igniters! > > I found, that in several places of IgniteKernal class code blocks are huge > and hard to understand and in other places methods have the same context > and could be placed in their own class. For example methods: > “ackAsciiLogo”, “ackConfigUrl”, “ackDaemon”, “ackOsInfo”, > “ackLanguageRuntime”, “ackRemoteManagement”, “ackVmArguments”, > “ackClassPaths”, “ackSystemProperties”, “ackEnviromentVariables”, > “ackMemoryConfiguration”, “ackCacheConfiguration”, “ackP2PConfiguration”, > “ackRebalanceConfiguration”, which are called in 800-813 lines and together > contain over than 250 lines, can be placed in separate class > “AckVariousInformation”. > > Do you think that it will be good to create task on such refactoring? > I think this is a matter of taste. One could argue that the code is more readable now because these methods belong to IgniteKernal and are not called from any other place. I would generally such changes.
