> Could you please explain profit of doing this? The point is that pull requests should not be left open. Either close them manually or use that autoclose feature.
On Tue, Dec 5, 2017 at 4:02 PM, Anton Vinogradov <[email protected]> wrote: > Pavel, > > >> There is corresponding > >> modules\platforms\dotnet\Apache.Ignite.Core\Cluster\IClusterMetrics.cs > in > >> .NET. > > Got it. > > >> PS Looks like you don't close pull requests when merging them to master. > >> Please make sure to include "This closes #prnum" in the commit messages, > >> as the autogenerated comments in JIRA suggest. > > Could you please explain profit of doing this? > > On Tue, Dec 5, 2017 at 2:27 PM, Pavel Tupitsyn <[email protected]> > wrote: > > > Anton, > > > > https://issues.apache.org/jira/browse/IGNITE-6869 adds new properties to > > ClusterMetrics. > > There is corresponding > > modules\platforms\dotnet\Apache.Ignite.Core\Cluster\IClusterMetrics.cs > in > > .NET. > > Actually, IGNITE-6869 has a comment from Vladimir about this. > > > > Same thing for IGNITE-6870, IGNITE-6903, IGNITE-6902, etc. > > > > > > PS Looks like you don't close pull requests when merging them to master. > > Please make sure to include "This closes #prnum" in the commit messages, > > as the autogenerated comments in JIRA suggest. > > > > > > On Tue, Dec 5, 2017 at 12:41 PM, Anton Vinogradov < > > [email protected]> > > wrote: > > > > > Pavel, > > > > > > These changes mostly about JMX Beans. > > > Could you please explain what should be added to .Net? Provide some > > > examples please. > > > > > > On Tue, Dec 5, 2017 at 10:40 AM, Pavel Tupitsyn <[email protected]> > > > wrote: > > > > > > > Hi Anton, > > > > > > > > Looks like none of the new metrics are added on .NET side. > > > > Please make sure it happens, either as part of existing tickets or > > > > separately. > > > > > > > > Thanks, > > > > Pavel > > > > > > > > On Thu, Nov 16, 2017 at 4:32 AM, Denis Magda <[email protected]> > > wrote: > > > > > > > > > Ok, closed the previously existed as a duplicate and add another > > > > usability > > > > > issue to fix in the scope of this IEP: > > > > > https://issues.apache.org/jira/browse/IGNITE-6925 < > > > > > https://issues.apache.org/jira/browse/IGNITE-6925> > > > > > > > > > > — > > > > > Denis > > > > > > > > > > > On Nov 15, 2017, at 9:21 AM, Anton Vinogradov < > > > > [email protected]> > > > > > wrote: > > > > > > > > > > > > Denis, > > > > > > > > > > > > It looks like [1] is a duplicate of [2] and [3] > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-5796 > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-6903 > > > > > > [3] https://issues.apache.org/jira/browse/IGNITE-6902 > > > > > > > > > > > > Please close issue as duplicate in case that's true. > > > > > > > > > > > > On Wed, Nov 15, 2017 at 11:18 AM, Vladimir Ozerov < > > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > >> Dima, > > > > > >> > > > > > >> This appears to be a INFRA's bug. I filed a ticket [1]. > > > > > >> > > > > > >> [1] https://issues.apache.org/jira/browse/INFRA-15487 > > > > > >> > > > > > >> On Tue, Nov 14, 2017 at 9:25 PM, Dmitriy Setrakyan < > > > > > [email protected]> > > > > > >> wrote: > > > > > >> > > > > > >>> On Tue, Nov 14, 2017 at 10:12 AM, Anton Vinogradov < > > > > > >>> [email protected] > > > > > >>>> wrote: > > > > > >>> > > > > > >>>> Dmitriy, > > > > > >>>> > > > > > >>>> It looks like a confluence bug. > > > > > >>>> Please login and push refresh button at issues list. > > > > > >>>> > > > > > >>> > > > > > >>> Works now. It is unfortunate that it does not work for the > > > community > > > > > >>> members who do not login. Perhaps we can provide a link to the > > Jira > > > > > >> filter, > > > > > >>> so folks could click on it and view the tickets. > > > > > >>> > > > > > >> > > > > > > > > > > > > > > > > > > > >
