Hi Denis, Thank you for looking at the proposal and raising these questions! We'll take them to discuss offline and will address your recommendations in the next revision.
I will let Vladimir comment on the QueryEntity here though to make sure we are on the same page. Thanks, P. On Thu, Apr 12, 2018 at 2:48 PM, Denis Magda <dma...@apache.org> wrote: > Hello Pavel, > > Thanks for the update. Haven't heard from you guys for a while but seems > you were too busy polishing the client. Looks great! > > Please consider several questions/notes: > > - Do we really want to migrate QueryEntity API [1] to Node.JS client? I > heard we planned to deprecate it in the future. *Vladimir*, please share > your thoughts. > - I wouldn't mix key-value and SQL examples together because they > represent different use cases of Ignite. For the sake of simplicity, I > would create a single SqlExample file that uses DDL to configure > tables/cache, inserts data with INSERTS and SELECTs it back (simple > queries > and queries with JOINs). We can base it on the database and queries used > here [2]. Happy to brainstorm on this with you separately. > - > > > [1] > https://github.com/nobitlost/ignite/blob/master/modules/ > clients/nodejs/examples/SqlQueryExample.js#L68 > [2] https://apacheignite-sql.readme.io/docs/getting-started > > -- > Denis > > On Wed, Apr 11, 2018 at 6:45 PM, Pavel Petroshenko <pa...@petroshenko.com> > wrote: > > > Igniters, > > > > Just to give you an update on the next iteration of the Ignite Node.js > thin > > client implementation. > > > > The second iteration is available for review/testing. > > > > The changes are available in the pull request [1] or directly from our > > repository [2]. > > > > The short README file [3] covers: > > > > - the list of supported features > > - simple instructions: > > * how to install the client > > * how to run the examples > > * how to run the tests > > > > And we actually encourage you to give it a look or even a try. > > > > The APIs are available both: in sources [4] and in a form of a generated > > specification, produced automatically from the jsdoc comments [5] > > > > Please let us know if you have any questions. > > > > Thanks! > > > > P. > > > > [1] https://github.com/apache/ignite/pull/3680 > > [2] https://github.com/nobitlost/ignite/tree/master/modules/ > clients/nodejs > > [3] https://github.com/nobitlost/ignite/blob/master/ > > modules/clients/nodejs/README.md > > [4] https://github.com/nobitlost/ignite/blob/master/ > > modules/clients/nodejs/lib > > [5] https://rawgit.com/nobitlost/ignite/master/modules/clients/ > nodejs/api_ > > spec/index.html > > >
