Another issue that may lead to incorrect recovery on node startup is https://issues.apache.org/jira/browse/IGNITE-8464 which is already in PA. I suggest we also include it to 2.5 given that fix improves stability of the persistence layer. Any objections?
2018-05-17 16:55 GMT+03:00 Ivan Rakov <ivan.glu...@gmail.com>: > Andrey, Igniters, > > I bumped into this issue while trying to reproduce another: > https://issues.apache.org/jira/browse/IGNITE-8320 > I think, this fix worth being cherry-picked into 2.5. Possibility of > AssertionError on persistence level is really undesirable for Ignite as a > product. > > Best Regards, > Ivan Rakov > > > On 14.05.2018 15:59, Andrey Gura wrote: > >> Igniters, >> >> we are ready to start process of releasing Apache Ignite 2.5. >> >> So code freeze. No more commits to ignite-2.5 branch. >> >> Thanks! >> >> >> On Thu, May 10, 2018 at 8:02 PM, Andrey Gura <ag...@apache.org> wrote: >> >>> Igniters, >>> >>> Almost all issues for Apache Ignite 2.5 release are fixed. Issues that >>> are still in Open state will be moved to 2.6 release. >>> >>> Code freeze for ignite-2.5 branch is planed for tomorrow. >>> >>> Thanks! >>> >>> On Tue, May 8, 2018 at 7:09 PM, Andrey Gura <ag...@apache.org> wrote: >>> >>>> Thanks for fast update, Ivan. >>>> >>>> On Tue, May 8, 2018 at 5:59 PM, Ivan Rakov <ivan.glu...@gmail.com> >>>> wrote: >>>> >>>>> Andrey, >>>>> >>>>> Sorry to disturb you again. I have a follow up fix for IGNITE-8429 - >>>>> https://issues.apache.org/jira/browse/IGNITE-8453. >>>>> Please merge it to master and ignite-2.5. >>>>> >>>>> Best Regards, >>>>> Ivan Rakov >>>>> >>>>> >>>>> On 08.05.2018 15:29, Vladimir Ozerov wrote: >>>>> >>>>>> H2 version updated is moved to AI 2.6. There are several serious >>>>>> problems, >>>>>> main - spatial dependency replacement which is a breaking change. >>>>>> >>>>>> On Tue, May 8, 2018 at 10:17 AM, Pavel Tupitsyn <ptupit...@apache.org >>>>>> > >>>>>> wrote: >>>>>> >>>>>> IGNITE-8434 merged to master, cherry-picked to ignite-2.5. >>>>>>> >>>>>>> Thank you, Andrey! >>>>>>> >>>>>>> On Mon, May 7, 2018 at 10:46 PM, Andrey Gura <ag...@apache.org> >>>>>>> wrote: >>>>>>> >>>>>>> Pavel, >>>>>>>> >>>>>>>> issue is targeted to release 2.5 now. Thanks! >>>>>>>> >>>>>>>> On Mon, May 7, 2018 at 10:40 PM, Pavel Tupitsyn < >>>>>>>> ptupit...@apache.org> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Igniters, >>>>>>>>> >>>>>>>>> There is an unpleasant bug in .NET [1]: >>>>>>>>> Services do not work at all on .NET Core and sometimes on classic >>>>>>>>> .NET. >>>>>>>>> >>>>>>>>> I'm almost done with the fix and I think we should include it in >>>>>>>>> 2.5. >>>>>>>>> >>>>>>>> Users >>>>>>>> >>>>>>>>> are complaining [2]. >>>>>>>>> >>>>>>>>> >>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-8434 >>>>>>>>> [2] >>>>>>>>> http://apache-ignite-users.70518.x6.nabble.com/Re- >>>>>>>>> >>>>>>>> Service-Grid-and-net-core-2-td21318.html >>>>>>>> >>>>>>>>> On Mon, May 7, 2018 at 6:44 PM, Vladimir Ozerov < >>>>>>>>> voze...@gridgain.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Andrey, >>>>>>>>>> >>>>>>>>>> I realized that we missed one very important thing - H2 version >>>>>>>>>> >>>>>>>>> upgrade >>>>>>> >>>>>>>> [1]. This is very important thing because new version contain >>>>>>>>>> >>>>>>>>> optimization >>>>>>>> >>>>>>>>> to IN clause processing. All we need is to upgrade H2 vesion from >>>>>>>>>> >>>>>>>>> 1.4.196 >>>>>>>> >>>>>>>>> to 1.4.197 and re-run tests. Can we target it to 2.5 release? >>>>>>>>>> >>>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-4150 >>>>>>>>>> >>>>>>>>>> On Mon, May 7, 2018 at 6:07 PM, Andrey Gura <ag...@apache.org> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Ivan, >>>>>>>>>>> >>>>>>>>>>> ok, targeted to 2.5. Thanks! >>>>>>>>>>> >>>>>>>>>>> On Mon, May 7, 2018 at 5:24 PM, Dmitry Pavlov < >>>>>>>>>>> >>>>>>>>>> dpavlov....@gmail.com> >>>>>>> >>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Thank you, Andrey, >>>>>>>>>>>> >>>>>>>>>>>> I saw 1 more proposal in separate topic >>>>>>>>>>>> http://apache-ignite-developers.2346864.n4.nabble. >>>>>>>>>>>> >>>>>>>>>>> com/RE-Hi-can-we-squeeze-this-into-2-5-https-issues-apache- >>>>>>>>>>> org-jira-browse-IGNITE-8439-td30161.html >>>>>>>>>>> >>>>>>>>>>>> and 1 proposal here related to ML: >>>>>>>>>>>> http://apache-ignite-developers.2346864.n4.nabble. >>>>>>>>>>>> >>>>>>>>>>> com/Apache-Ignite-2-5-release-td28927i20.html#a30155 >>>>>>>>>>> >>>>>>>>>>>> but here Yuriy Babak probably should share his opinion. >>>>>>>>>>>> >>>>>>>>>>>> Sincerely, >>>>>>>>>>>> Dmitriy Pavlov >>>>>>>>>>>> >>>>>>>>>>>> пн, 7 мая 2018 г. в 17:09, Andrey Gura <ag...@apache.org>: >>>>>>>>>>>> >>>>>>>>>>>>> Sergey, Dmitry, >>>>>>>>>>>>> >>>>>>>>>>>>> I've targeted your issues to 2.5 release. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks! >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, May 4, 2018 at 5:51 PM, Dmitry Pavlov < >>>>>>>>>>>>> >>>>>>>>>>>> dpavlov....@gmail.com> >>>>>>>> >>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> I did not understand process. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Is it required to receive someone reply that issue is agreed >>>>>>>>>>>>>> to >>>>>>>>>>>>>> >>>>>>>>>>>>> be >>>>>>>> >>>>>>>>> included >>>>>>>>>>>>>> into release? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Or because there is no response I can cherry-pick anything to >>>>>>>>>>>>>> >>>>>>>>>>>>> 2.5 >>>>>>> >>>>>>>> hoping >>>>>>>>>>> >>>>>>>>>>>> it >>>>>>>>>>>>>> is lazy consensus; no one objected. >>>>>>>>>>>>>> >>>>>>>>>>>>>> пт, 4 мая 2018 г. в 17:44, Denis Magda <dma...@apache.org>: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Igniters, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I got lost. Were all the bugs reported in this thread fixed >>>>>>>>>>>>>>> >>>>>>>>>>>>>> and >>>>>>> >>>>>>>> merged >>>>>>>>>>> >>>>>>>>>>>> into >>>>>>>>>>>>>>> 2.5 branch? Is there any bug which fix is still in progress? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Just want to know when the QA and bugs fixing stage is over. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Denis >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, May 3, 2018 at 9:14 AM, Dmitry Pavlov < >>>>>>>>>>>>>>> >>>>>>>>>>>>>> dpavlov....@gmail.com >>>>>>>>>> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Andrey, Igniters, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I propose to include >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-8347 >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> fix >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> to 2.5. It is quite isolated. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Memory leak can be reproduced if node in embedded mode is >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> restarted >>>>>>>>>> >>>>>>>>>>> under >>>>>>>>>>>>>>>> the same process (thread is alive and cleanup is not >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> performed). >>>>>>>> >>>>>>>>> Sincerely, >>>>>>>>>>>>>>>> Dmitriy Pavlov >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> сб, 28 апр. 2018 г. в 19:49, Sergey Chugunov >>>>>>>>>>>>>>>> <sergey.chugu...@gmail.com >>>>>>>>>>>>>>>> : >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Igniters, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I would like to include into release another critical bug >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> found >>>>>>>> >>>>>>>>> in >>>>>>>>>>> >>>>>>>>>>>> ZooKeeper Discovery [1]. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Situation reproducing the error is very specific and rare >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> but >>>>>>>> >>>>>>>>> it >>>>>>>>>> >>>>>>>>>>> leads >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> to >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> full cluster shut down. At the same time fix for it very >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> simple >>>>>>>> >>>>>>>>> and >>>>>>>>>>> >>>>>>>>>>>> I >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> don't >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> expect it is too risky. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-8421 >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Sat, Apr 28, 2018 at 6:08 PM Alexei Scherbakov < >>>>>>>>>>>>>>>>> alexey.scherbak...@gmail.com> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Guys, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Consider including this [1] to release. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> It's major usability issue and if not fixed now will >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> lead >>>>>>> >>>>>>>> to >>>>>>>> >>>>>>>>> compatibility >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> issues in subsequent release. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-8418 >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> пт, 27 апр. 2018 г. в 21:34, Andrey Gura < >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> ag...@apache.org>: >>>>>>>> >>>>>>>>> Of course I meant bug fixes, not bugs :) >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Fri, Apr 27, 2018 at 9:28 PM, Andrey Gura < >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> ag...@apache.org> >>>>>>>>>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Eduard, Pavel, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> mentioned bugs are good candidates for including to >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> release. >>>>>>>>>>> >>>>>>>>>>>> Targeted to 2.5. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks! >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Fri, Apr 27, 2018 at 5:06 PM, Pavel Kovalenko < >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> jokse...@gmail.com >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Igniters, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> I would like to add this issue >>>>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-8405 >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> to >>>>>>> >>>>>>>> 2.5 >>>>>>>>>> >>>>>>>>>>> scope. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> 2018-04-27 16:59 GMT+03:00 Eduard Shangareev < >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> eshangar...@gridgain.com >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> : >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Guys, >>>>>>>>>>>>>>>>>>>>>> I have finished >>>>>>>>>>>>>>>>>>>>>> ttps://issues.apache.org/jira/browse/IGNITE-7628. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> It looks like a good candidate to merge to 2.5. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> On Fri, Apr 27, 2018 at 1:32 PM, Ivan Rakov < >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> ivan.glu...@gmail.com >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Dmitriy, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> There are some notes about WAL compaction in >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> "Persistence >>>>>>>>>>> >>>>>>>>>>>> Under >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hood" >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> article: >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/ >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Ignite+ >>>>>>>> >>>>>>>>> Persistent+Store+-+under+the+ >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> hood#IgnitePersistentStore-und >>>>>>>>>>> >>>>>>>>>>>> erthehood-WALcompaction >>>>>>>>>>>>>>>>>>>>>>> Please take a look - it has all the answers. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>>>>> Ivan Rakov >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> On 27.04.2018 2:28, Dmitriy Setrakyan wrote: >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> On Fri, Apr 27, 2018 at 6:38 AM, Ivan Rakov < >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> ivan.glu...@gmail.com> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Folks, >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>>> I have a fix for a critical issue related to >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> WAL >>>>>>> >>>>>>>> compaction: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> https://issues.apache.org/ >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> jira/browse/IGNITE-8393 >>>>>>>> >>>>>>>>> In short, if part of WAL archive is broken, >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> attempt >>>>>>>> >>>>>>>>> to >>>>>>>>>>> >>>>>>>>>>>> compress >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> it >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> may >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> result in spamming warnings in infinite loop. >>>>>>>>>>>>>>>>>>>>>>>>> I think it's also worth being included in 2.5 >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> release. >>>>>>>>>>> >>>>>>>>>>>> Let's include it, especially given that the >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> fix >>>>>>> >>>>>>>> is >>>>>>>> >>>>>>>>> done. >>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> Ivan, on another note, is WAL compaction >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> described >>>>>>>> >>>>>>>>> anywhere? >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> What >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> do we >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> do >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> internally to compact WAL and by what factor >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> are >>>>>>> >>>>>>>> we >>>>>>>> >>>>>>>>> able >>>>>>>>>>> >>>>>>>>>>>> to >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> reduce >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> WAL >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> file size? >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> D. >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>> Best regards, >>>>>>>>>>>>>>>>>>>>>> Eduard. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Best regards, >>>>>>>>>>>>>>>>>> Alexei Scherbakov >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >
